From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZPAu-00052F-1J for mharc-grub-devel@gnu.org; Sat, 30 Aug 2008 08:03:28 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZPAt-00052A-3g for grub-devel@gnu.org; Sat, 30 Aug 2008 08:03:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZPAr-00051y-IM for grub-devel@gnu.org; Sat, 30 Aug 2008 08:03:26 -0400 Received: from [199.232.76.173] (port=38867 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZPAr-00051v-G2 for grub-devel@gnu.org; Sat, 30 Aug 2008 08:03:25 -0400 Received: from aybabtu.com ([69.60.117.155]:46973) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KZPAq-0003lG-TR for grub-devel@gnu.org; Sat, 30 Aug 2008 08:03:25 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KZP10-0006sd-RX for grub-devel@gnu.org; Sat, 30 Aug 2008 13:53:15 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KZP9N-0001ML-WC for grub-devel@gnu.org; Sat, 30 Aug 2008 14:01:54 +0200 Date: Sat, 30 Aug 2008 14:01:53 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080830120153.GG16775@thorin> References: <1219943377.4598.56.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1219943377.4598.56.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] new static const char[] modname X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Aug 2008 12:03:27 -0000 On Thu, Aug 28, 2008 at 07:09:37PM +0200, Felix Zielcke wrote: > @@ -248,7 +250,7 @@ grub_scsi_open (const char *name, grub_d > { > if (! p->open (name, scsi)) > { > - disk->id = (unsigned long) "scsi"; /* XXX */ > + disk->id = (unsigned long) modname; /* XXX */ I think the idea with this was to unify the strings for grub_dprintf calls; your patch goes a bit further and also puts other sort of strings to share the same variable. I think that's a bit dangerous, since changes intended for one use of the variable could collaterally affect the rest in subtle ways. And it's not that useful in code size anyway. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."