From: David Miller <davem@davemloft.net>
To: root@danielinux.net
Cc: netdev@vger.kernel.org, angelo.tornese@gmail.com
Subject: Re: [PATCH] *icsk_ca_priv: Reduce inet_connection_sock size?
Date: Sun, 31 Aug 2008 21:03:31 -0700 (PDT) [thread overview]
Message-ID: <20080831.210331.252498451.davem@davemloft.net> (raw)
In-Reply-To: <48BAE26A.4060002@danielinux.net>
From: Daniele Lacamera <root@danielinux.net>
Date: Sun, 31 Aug 2008 20:26:50 +0200
> This simple patch (2.6.26) replaces the icsk_ca_priv big array with a
> void pointer, reducing the default inet_connection_sock size by 60Bytes.
>
> Each "congestion controlled" socket must allocate and free its own priv
> structure if needed, from the connection init and release callbacks
> inside each module.
>
> Wouldn't this reduce memory usage for sockets that don't use ca?
Yes, but for every TCP socket there is a new memory allocation and
free.
We're trying to decrease the number of those rather than increase them
because having more of them non-trivially impacts TCP connection
rates.
next prev parent reply other threads:[~2008-09-01 4:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-31 18:26 [PATCH] *icsk_ca_priv: Reduce inet_connection_sock size? Daniele Lacamera
2008-08-31 19:09 ` Evgeniy Polyakov
2008-08-31 19:19 ` Daniele Lacamera
2008-08-31 20:22 ` Evgeniy Polyakov
2008-08-31 21:35 ` Daniele Lacamera
2008-09-01 4:05 ` David Miller
2008-09-01 4:03 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-31 18:05 Daniele Lacamera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080831.210331.252498451.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=angelo.tornese@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=root@danielinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.