From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZpEf-0002QO-F8 for mharc-grub-devel@gnu.org; Sun, 31 Aug 2008 11:53:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZpEc-0002PK-53 for grub-devel@gnu.org; Sun, 31 Aug 2008 11:53:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZpEa-0002Oj-L0 for grub-devel@gnu.org; Sun, 31 Aug 2008 11:53:01 -0400 Received: from [199.232.76.173] (port=37873 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZpEa-0002Oa-9I for grub-devel@gnu.org; Sun, 31 Aug 2008 11:53:00 -0400 Received: from gateway10.websitewelcome.com ([67.18.124.14]:54296) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KZpEa-0005e4-0C for grub-devel@gnu.org; Sun, 31 Aug 2008 11:53:00 -0400 Received: (qmail 5839 invoked from network); 31 Aug 2008 15:54:50 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway10.websitewelcome.com with SMTP; 31 Aug 2008 15:54:50 -0000 Received: from c-67-185-142-228.hsd1.wa.comcast.net ([67.185.142.228]:52154 helo=gamma.lan) by gator297.hostgator.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1KZp85-0003xU-2c; Sun, 31 Aug 2008 10:46:17 -0500 Date: Sun, 31 Aug 2008 08:46:13 -0700 From: Colin D Bennett To: The development of GRUB 2 Message-ID: <20080831084613.51ea00d8@gamma.lan> In-Reply-To: <48B8D666.5040502@mandel.name> References: <48B75500.9080706@mandel.name> <48B80E15.1070103@nic.fi> <48B8D666.5040502@mandel.name> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.11; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/kBDv_qKfTMY.RboYLo1963f"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Cc: olaf@mandel.name Subject: Re: [patch] background_image: image centering and scaling X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2008 15:53:02 -0000 --Sig_/kBDv_qKfTMY.RboYLo1963f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 29 Aug 2008 22:11:02 -0700 Olaf Mandel wrote: > Vesa J=C3=A4=C3=A4skel=C3=A4inen schrieb: > -Snipp- > > I will however look at if there are some ideas that you have > > provided what is still missing from new graphical menu > > implementation that should be there. > -Snipp- >=20 > Hello, >=20 > thanks. I must admit to not looking at the source code for the > project. Will scaling also be used for "simple" background_image > commands? If yes and if the scaling does preserve the aspect ratio of > the image, then the background picture is not necessarily in the > upper left corner of the screen (an assumption in the code in grub2 > trunk). >=20 > I hope some version of the gfxmenu project finds its way into the > trunk of the grub2 repository soon. :-) >=20 > Best regards, > Olaf Hi Olaf, Thanks for your work! It would be great if you wanted to enhance my code by adding a preserve-aspect-ratio mode; currently my background_image command scales to fit the screen without regard for the image's original aspect ratio. Currently the '--mode' / '-m' option to 'background_image' accepts the following values: stretch Stretch the image to fit without regard for the original aspect ratio. normal Do not scale the image; origin anchored to upper-left corner. I think if you added a "fit" option which would fit the image preserving aspect, that would be nice. Also, you could either add a "center" option which would center the background image without altering its size. I think the "normal" option will not be very desirable when scaling and centering are both available, since I can't imagine why you'd want an image stuck in the corner instead of centered or scaled in some way. If you want to see the code for this, take a look at the message I sent to the grub-devel list today entitled "[PATCH] GSoC #09 Bitmap scaling". This patch may require some of the prior patches as well, however (possibly #06 and/or #07). Regards, Colin --Sig_/kBDv_qKfTMY.RboYLo1963f Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAki6vMgACgkQokx8fzcGbYd0dQCfUxrVH6UtbMfKY0xmX/Ol1o9d R8QAoIPdgtm5PNqcXURNU61qtKEYHVuk =HQN9 -----END PGP SIGNATURE----- --Sig_/kBDv_qKfTMY.RboYLo1963f--