From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZpKo-0004Db-G9 for mharc-grub-devel@gnu.org; Sun, 31 Aug 2008 11:59:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZpKn-0004DC-0U for grub-devel@gnu.org; Sun, 31 Aug 2008 11:59:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZpKk-0004CO-Hb for grub-devel@gnu.org; Sun, 31 Aug 2008 11:59:24 -0400 Received: from [199.232.76.173] (port=48153 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZpKk-0004CJ-Dr for grub-devel@gnu.org; Sun, 31 Aug 2008 11:59:22 -0400 Received: from gateway01.websitewelcome.com ([69.56.142.19]:40074) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KZpKj-0007sz-Lu for grub-devel@gnu.org; Sun, 31 Aug 2008 11:59:21 -0400 Received: (qmail 32122 invoked from network); 31 Aug 2008 16:14:52 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway01.websitewelcome.com with SMTP; 31 Aug 2008 16:14:52 -0000 Received: from c-67-185-142-228.hsd1.wa.comcast.net ([67.185.142.228]:40831 helo=gamma.lan) by gator297.hostgator.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1KZpKg-0004zR-G2; Sun, 31 Aug 2008 10:59:18 -0500 Date: Sun, 31 Aug 2008 08:59:14 -0700 From: Colin D Bennett To: The development of GRUB 2 Message-ID: <20080831085914.341797ab@gamma.lan> In-Reply-To: <1219918619.4598.43.camel@fz.local> References: <87prnuw7tl.fsf@xs4all.nl> <1219918619.4598.43.camel@fz.local> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.11; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/W1ansnT/qnv/ntZhLzFQoV4"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Cc: fzielcke@z-51.de Subject: Re: [RFC] USB Support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2008 15:59:25 -0000 --Sig_/W1ansnT/qnv/ntZhLzFQoV4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 28 Aug 2008 12:16:59 +0200 Felix Zielcke wrote: > + grub_usb_iterate (usb_iterate); > +} > + > +=0C >=20 > Weird `=0C' character which seems not to make sense. Actually that is a form feed character, which the GNU coding standard recommends to be used to break up source code at logical places: Please use formfeed characters (control-L) to divide the program into pages at logical places (but not within a function). It does not matter just how long the pages are, since they do not have to fit on a printed page. The formfeeds should appear alone on lines by themselves.=20 (http://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting) > Index: bus/usb/uhci.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- bus/usb/uhci.c (revision 0) > +++ bus/usb/uhci.c (revision 0) >=20 >=20 > + fail: > + if (u) > + { > + grub_free ((void *) u->qh); > + grub_free (u->framelist); > + } > + grub_free (u); >=20 > util/misc.c: grub_free () doestn't check *ptr before calling free () > But better util/misc.c get's changed then your code and bus/usb/uhci > isn't compiled for grub-emu anyway :) But the C standard says it's OK to call free() with a NULL pointer. Regards, Colin --Sig_/W1ansnT/qnv/ntZhLzFQoV4 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAki6v9UACgkQokx8fzcGbYdEgQCaAhhtX74fF0KSjAVwn3hHPiDS qzIAoIcIaDvWH4Nyo1kbuPPXeX557Q9m =cTdl -----END PGP SIGNATURE----- --Sig_/W1ansnT/qnv/ntZhLzFQoV4--