From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZn5S-00049R-7o for mharc-grub-devel@gnu.org; Sun, 31 Aug 2008 09:35:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZn5Q-00048k-B3 for grub-devel@gnu.org; Sun, 31 Aug 2008 09:35:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZn5O-00047h-Oq for grub-devel@gnu.org; Sun, 31 Aug 2008 09:35:23 -0400 Received: from [199.232.76.173] (port=33048 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZn5O-00047a-Gx for grub-devel@gnu.org; Sun, 31 Aug 2008 09:35:22 -0400 Received: from aybabtu.com ([69.60.117.155]:34036) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KZn5O-0004b5-2l for grub-devel@gnu.org; Sun, 31 Aug 2008 09:35:22 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KZmvR-0006SY-BE for grub-devel@gnu.org; Sun, 31 Aug 2008 15:25:05 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KZn3z-0000mZ-P6 for grub-devel@gnu.org; Sun, 31 Aug 2008 15:33:55 +0200 Date: Sun, 31 Aug 2008 15:33:55 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080831133355.GC2688@thorin> References: <20080830122626.GA5899@thorin> <20080830114118.3zltziz18g0ss8ws-cebfxv@webmail.spamcop.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080830114118.3zltziz18g0ss8ws-cebfxv@webmail.spamcop.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix disk->id abuse X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2008 13:35:24 -0000 On Sat, Aug 30, 2008 at 11:41:18AM -0400, Pavel Roskin wrote: > Quoting Robert Millan : > > >So this patch means to solve both issues; makes single-disk drivers use a > >constant directly (since a pointer to string is meaningless and confusing), > >and disk/scsi.c use LUNs which (I believe) will work as unique identifiers. > > Multi-character constants cause warnings. Can we silence them? > That's why I changed them > to strings. Pointers to different strings are different, and that's > all we need. For single-disk drivers, yes. But that has two problems: - People tend to think the string itself has a meaning. We could avoid this by using "dummy" or so. - People tend to think it's fine to do the same for multi-disk drivers. We could avoid this by adding a short comment in each of them. > If you prefer numeric IDs, perhaps we'll need a header > file with all IDs we support. Alternatively, we need a macro that > would convert characters to an ID. I agree that this is harder to maintain. I'd be happy with any solution that works correctly and prevents confusion. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."