From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZnIs-0002xk-SB for mharc-grub-devel@gnu.org; Sun, 31 Aug 2008 09:49:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZnIr-0002xf-8m for grub-devel@gnu.org; Sun, 31 Aug 2008 09:49:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZnIp-0002xT-VH for grub-devel@gnu.org; Sun, 31 Aug 2008 09:49:16 -0400 Received: from [199.232.76.173] (port=38683 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZnIp-0002xQ-Rh for grub-devel@gnu.org; Sun, 31 Aug 2008 09:49:15 -0400 Received: from aybabtu.com ([69.60.117.155]:38182) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KZnIp-0001L5-C5 for grub-devel@gnu.org; Sun, 31 Aug 2008 09:49:15 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KZn8s-0006T8-HG for grub-devel@gnu.org; Sun, 31 Aug 2008 15:38:58 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KZnHO-0000tL-VP for grub-devel@gnu.org; Sun, 31 Aug 2008 15:47:46 +0200 Date: Sun, 31 Aug 2008 15:47:46 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080831134746.GD2688@thorin> References: <1220127336.21696.30.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1220127336.21696.30.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] iso9660 UUID support by using the creation date/time X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2008 13:49:17 -0000 On Sat, Aug 30, 2008 at 10:15:36PM +0200, Felix Zielcke wrote: > Here's a patch which implements UUID support for the iso9660 filesystem, > by using the creation date in the `superblock'. Nice work :-) > The specs say that it's allowed to contain only zeros but I think this > shouldn't be a big problem. I think this could indeed be a problem if it leads to collisions. If "all zeroes" is detected, one could rise an error in uuid() function to prevent the caller from taking the value into consideration. > + *uuid = grub_malloc (sizeof (struct grub_iso9660_date) + sizeof ('\0')); > + grub_sprintf (*uuid, "%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%02u", > + data->voldesc.created.year[0], data->voldesc.created.year[1], > + data->voldesc.created.year[2], data->voldesc.created.year[3], > + data->voldesc.created.month[0], data->voldesc.created.month[1], > + data->voldesc.created.day[0], data->voldesc.created.day[1], > + data->voldesc.created.hour[0], data->voldesc.created.hour[1], > + data->voldesc.created.minute[0], data->voldesc.created.minute[1], > + data->voldesc.created.second[0], data->voldesc.created.second[2], > + data->voldesc.created.hundredth[0], data->voldesc.created.hundredth[1], > + data->voldesc.created.offset); Since the string contains human-readable information, may I suggest separating it with dashes to make it easier to comprehend? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."