From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KZnKk-0003ZG-55
	for mharc-grub-devel@gnu.org; Sun, 31 Aug 2008 09:51:14 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KZnKi-0003Yv-U0
	for grub-devel@gnu.org; Sun, 31 Aug 2008 09:51:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KZnKi-0003Yd-Cy
	for grub-devel@gnu.org; Sun, 31 Aug 2008 09:51:12 -0400
Received: from [199.232.76.173] (port=53641 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KZnKi-0003YZ-7o
	for grub-devel@gnu.org; Sun, 31 Aug 2008 09:51:12 -0400
Received: from aybabtu.com ([69.60.117.155]:38183)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1KZnKh-00020I-Ru
	for grub-devel@gnu.org; Sun, 31 Aug 2008 09:51:12 -0400
Received: from [192.168.10.10] (helo=thorin)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69) (envelope-from <rmh@aybabtu.com>) id 1KZnAl-0006TX-44
	for grub-devel@gnu.org; Sun, 31 Aug 2008 15:40:55 +0200
Received: from rmh by thorin with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>) id 1KZnJJ-0000ux-J0
	for grub-devel@gnu.org; Sun, 31 Aug 2008 15:49:45 +0200
Date: Sun, 31 Aug 2008 15:49:45 +0200
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20080831134945.GE2688@thorin>
References: <20080830234341.662e6132@gamma.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080830234341.662e6132@gamma.lan>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.13 (2006-08-11)
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] GSoC #01 grub-mkrescue i386-pc multiple overlays
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Aug 2008 13:51:13 -0000

On Sat, Aug 30, 2008 at 11:43:41PM -0700, Colin D Bennett wrote:
> === modified file 'util/i386/pc/grub-mkrescue.in'
> --- util/i386/pc/grub-mkrescue.in	2008-07-12 14:40:50 +0000
> +++ util/i386/pc/grub-mkrescue.in	2008-08-30 18:33:46 +0000
> @@ -71,7 +71,7 @@
>      --modules=*)
>  	modules=`echo "$option" | sed 's/--modules=//'` ;;
>      --overlay=*)
> -	overlay=`echo "$option" | sed 's/--overlay=//'` ;;
> +	overlay=${overlay}${overlay:+ }`echo "$option" | sed 's/--overlay=//'` ;;
>      --pkglibdir=*)
>  	input_dir=`echo "$option" | sed 's/--pkglibdir=//'` ;;
>      --grub-mkimage=*)
> @@ -124,9 +124,10 @@
>    echo "insmod $i"
>  done > ${aux_dir}/boot/grub/grub.cfg
>  
> -if test "x$overlay" = x ; then : ; else
> -  cp -dpR ${overlay}/* ${aux_dir}/
> -fi
> +for d in ${overlay}; do
> +  echo "Overlaying $d"
> +  cp -dpR "${d}"/* "${aux_dir}"/
> +done
>  
>  if [ "x${image_type}" = xfloppy -o "x${emulation}" = xfloppy ] ; then
>    # build memdisk

Hi,

I'd suggest mentioning in --help that --overlay can be specified multiple
times.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."