Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication.

[Gleb Natapov <gleb@qumranet.com>]

With the fix below this patch series works for me.

On Sun, Aug 31, 2008 at 04:39:34PM +0300, Blue Swirl wrote:
> +static uint8_t fw_cfg_read(FWCfgState *s)
> +{
> +    int arch = !!(s->cur_entry & FW_CFG_ARCH_LOCAL);
> +    FWCfgEntry *e = &s->entries[arch][s->cur_entry & ~FW_CFG_ARCH_LOCAL];
> +    uint8_t ret;
> +
> +    if (s->cur_entry != FW_CFG_INVALID || !e->data || s->cur_offset >= e->len)
This should be "=="     ^^^

> +        ret = 0;
> +    else
> +        ret = e->data[s->cur_offset++];
> +
> +    FW_CFG_DPRINTF("read %d\n", ret);
> +
> +    return ret;
> +}
> +


--
			Gleb.