From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 31 Aug 2008 17:04:14 +0200 Subject: [U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming In-Reply-To: References: Message-ID: <20080831150414.300AB24899@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Guennadi Liakhovetski, In message you wrote: > Use consistent naming for active and redundant environment variables, remove > redundant erase struct initialisation by using separate structs for the > active and redundant environments. This is another sylistic change that is IMHO not justified by any functional improvements or code fixes. If you are woking on other people's code you will have to accept that these other people have other preferences for variable names and the like. Reformatting the code and renaming variables just to make it better match your own style is IMHO not justified. Your new code gets longer, you even have to split a couple of lines because of that. That's not an improvement to me. I reject this patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "It is better to have tried and failed than to have failed to try, but the result's the same." - Mike Dennison