From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KZqFr-0005oS-Bd
	for mharc-grub-devel@gnu.org; Sun, 31 Aug 2008 12:58:23 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KZqFo-0005nc-Ec
	for grub-devel@gnu.org; Sun, 31 Aug 2008 12:58:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KZqFn-0005nP-Ac
	for grub-devel@gnu.org; Sun, 31 Aug 2008 12:58:19 -0400
Received: from [199.232.76.173] (port=58280 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KZqFn-0005nM-5j
	for grub-devel@gnu.org; Sun, 31 Aug 2008 12:58:19 -0400
Received: from aybabtu.com ([69.60.117.155]:51479)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1KZqFn-0007y5-1Z
	for grub-devel@gnu.org; Sun, 31 Aug 2008 12:58:19 -0400
Received: from [192.168.10.10] (helo=thorin)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69) (envelope-from <rmh@aybabtu.com>) id 1KZq5o-00071B-Lu
	for grub-devel@gnu.org; Sun, 31 Aug 2008 18:48:01 +0200
Received: from rmh by thorin with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>) id 1KZqEJ-0008P9-GM
	for grub-devel@gnu.org; Sun, 31 Aug 2008 18:56:47 +0200
Date: Sun, 31 Aug 2008 18:56:47 +0200
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20080831165647.GA32241@thorin>
References: <1220127336.21696.30.camel@fz.local> <20080831134746.GD2688@thorin>
	<1220192824.4354.11.camel@fz.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1220192824.4354.11.camel@fz.local>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.13 (2006-08-11)
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] iso9660 UUID support by using the creation date/time
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Aug 2008 16:58:21 -0000


Some more things I overlooked..

On Sun, Aug 31, 2008 at 04:27:04PM +0200, Felix Zielcke wrote:
> +struct grub_iso9660_date
> +{
> +  grub_uint8_t year[4];
> +  grub_uint8_t month[2];
> +  grub_uint8_t day[2];
> +  grub_uint8_t hour[2];
> +  grub_uint8_t minute[2];
> +  grub_uint8_t second[2];
> +  grub_uint8_t hundredth[2];
> +  grub_uint8_t offset;
> +}__attribute__ ((packed));
    ^

Please add a space here

> @@ -812,8 +826,59 @@ grub_iso9660_label (grub_device_t device
>    return grub_errno;
>  }
>  
> -

Please don't remove the ^Ls.
 
-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."