From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZrsQ-0005mH-6d for mharc-grub-devel@gnu.org; Sun, 31 Aug 2008 14:42:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZrsP-0005lj-06 for grub-devel@gnu.org; Sun, 31 Aug 2008 14:42:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZrsN-0005jx-9X for grub-devel@gnu.org; Sun, 31 Aug 2008 14:42:16 -0400 Received: from [199.232.76.173] (port=47932 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZrsN-0005jf-2N for grub-devel@gnu.org; Sun, 31 Aug 2008 14:42:15 -0400 Received: from aybabtu.com ([69.60.117.155]:40107) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KZrsM-0000zt-3M for grub-devel@gnu.org; Sun, 31 Aug 2008 14:42:14 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KZriM-0007Qi-Iq for grub-devel@gnu.org; Sun, 31 Aug 2008 20:31:55 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KZrqu-0002L1-1D for grub-devel@gnu.org; Sun, 31 Aug 2008 20:40:44 +0200 Date: Sun, 31 Aug 2008 20:40:44 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080831184044.GB8807@thorin> References: <1220127336.21696.30.camel@fz.local> <20080831134746.GD2688@thorin> <1220192824.4354.11.camel@fz.local> <20080831165647.GA32241@thorin> <1220203421.4354.34.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1220203421.4354.34.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] iso9660 UUID support by using the creation date/time X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Aug 2008 18:42:17 -0000 On Sun, Aug 31, 2008 at 07:23:41PM +0200, Felix Zielcke wrote: > + *uuid = grub_malloc (sizeof ("YYYY-MM-DD-HH-mm-ss-hh") Lovely :-) > + sizeof ('\0')); Is this really needed? sizeof("foo") implicitly includes the trailing \0. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."