From: Jean Delvare <khali@linux-fr.org>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: alsa-devel@alsa-project.org,
Vladimir Barinov <vbarinov@ru.mvista.com>,
ext Mark Brown <broonie@sirena.org.uk>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] ASoC: Convert tlv320aic3x to a new-style i2c driver
Date: Mon, 1 Sep 2008 14:27:26 +0200 [thread overview]
Message-ID: <20080901142726.2f7ebf2d@hyperion.delvare> (raw)
In-Reply-To: <20080901152038.5987df8d.jarkko.nikula@nokia.com>
On Mon, 1 Sep 2008 15:20:38 +0300, Jarkko Nikula wrote:
> On Mon, 1 Sep 2008 12:35:09 +0100
> "ext Mark Brown" <broonie@sirena.org.uk> wrote:
>
> > On Mon, Sep 01, 2008 at 02:31:14PM +0300, Jarkko Nikula wrote:
> > > "ext Jean Delvare" <khali@linux-fr.org> wrote:
> >
> > > Thanks. In N810 it's connected into second i2c bus so this makes it
> > > working
> >
> > > + .i2c_bus = 2,
> >
> > Should that be 1? Normally the buses are numbered from zero...
> >
> Good question. By some historical reason we are registering busses
> starting from number one in OMAP and short hack below (in linux-omap
> tree) trying to register them starting from zero didn't work out.
>
> But yeah, that's another issue in linux-omap and Jean's patch is
> working on N810 if changing this i2c_bus to 2.
OK, thanks Jarkko for testing and reporting. I'll make it 2 for the
time being so that things keep working, and it can be changed later if
needed.
--
Jean Delvare
prev parent reply other threads:[~2008-09-01 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 9:21 [PATCH] ASoC: Convert tlv320aic3x to a new-style i2c driver Jean Delvare
2008-09-01 11:31 ` Jarkko Nikula
2008-09-01 11:35 ` Mark Brown
2008-09-01 12:20 ` Jarkko Nikula
2008-09-01 12:27 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901142726.2f7ebf2d@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=vbarinov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.