From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KaHcw-000741-4i for qemu-devel@nongnu.org; Mon, 01 Sep 2008 18:12:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KaHcv-00073U-CO for qemu-devel@nongnu.org; Mon, 01 Sep 2008 18:12:01 -0400 Received: from [199.232.76.173] (port=52109 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaHcu-00073O-S2 for qemu-devel@nongnu.org; Mon, 01 Sep 2008 18:12:00 -0400 Received: from hall.aurel32.net ([91.121.138.14]:57515) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KaHcu-00058H-Ge for qemu-devel@nongnu.org; Mon, 01 Sep 2008 18:12:00 -0400 Date: Tue, 2 Sep 2008 00:11:57 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] SH4: convert fmov/fadd to TCG Message-ID: <20080901221157.GA15238@volta.aurel32.net> References: <48B9A131.7080400@juno.dti.ne.jp> <48BAD4DB.6070907@juno.dti.ne.jp> <20080831193203.GA32484@volta.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20080831193203.GA32484@volta.aurel32.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Shin-ichiro KAWASAKI On Sun, Aug 31, 2008 at 09:32:03PM +0200, Aurelien Jarno wrote: > On Mon, Sep 01, 2008 at 02:28:59AM +0900, Shin-ichiro KAWASAKI wrote: > > Thank your for comments, Blue Swirl! > > The new patch is shown at the end of this mail. > > Reviews are welcome, again. > > > > Thanks for you patch. It looks good, but it doesn't work here (on an > amd64 host): while the kernel is booting correctly with qemu-system-sh4, > running /usr/bin/cal with qemu-sh4 causes a segfault. > I have finally found the problem: the gen_ld_frN_FT and gen_st_frN_FT already have access to cpu_env, this value does not needed to be passed again. Passing it as a TCGv variable caused it to be truncated. At the end, looking at what other targets do, I have decided to convert the SH4 floating point ops the "MIPS way", which has the advantage of only using TCG temp instead of global FT0, FT1, DT0 and DT1 variables. I have committed that to the SVN, so the SH4 target is now fully converted to TCG. I have tested my changes using /usr/bin/awk with sh4-linux-user doing FP computations. In the next days/weeks, I'll try to convert the alpha target to TCG, as I need some more experience with TCG before doing the PowerPC one. I have seen that Tristan already send patches about that, I'll have a look later. -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net