From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 0/2] x86: fix memory leaks when doing CPU hotplug
Date: Tue, 2 Sep 2008 09:14:28 +0200 [thread overview]
Message-ID: <20080902071428.GA6743@alberich.amd.com> (raw)
In-Reply-To: <20080811194013.GI12788@elte.hu>
On Mon, Aug 11, 2008 at 09:40:15PM +0200, Ingo Molnar wrote:
>
> * Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
>
> > Following patches fix two memory leaks with CPU hotplug. Some per CPU
> > data is allocated each time a CPU is set online. But this space is
> > never freed.
> >
> > Usually this memory leak is not a big deal (for normal CPU hotplug
> > usage). But during stress tests with lots of CPU offline/online cycles
> > this really matters.
> >
> > The entire leak is 40K (10 pages) for each offline/online cycle per
> > CPU. I've verified both fixes performing more than 90000 CPU
> > offline/online cycles.
>
> applied to tip/x86/core, thanks Andreas.
>
> > This is not a regression but I think it's still 2.6.27 material.
> > Please apply.
>
> it's tricky code so i guess it's best to let it cook in tip/master a
> bit. If it does not show up upstream by say -rc4 time could you please
> ping us about it?
Ping!
It's -rc5 time and
b55793f7528ce1b73c25b3ac8a86a6cda2a0f9a4 (x86: cpu_init(): fix memory leak when using CPU hotplug)
49800efcb17afdf973f33e8aa8807b7f83993cc6 (x86: pda_init(): fix memory leak when using CPU hotplug)
are in tip/master but not yet upstream.
Regards,
Andreas
prev parent reply other threads:[~2008-09-02 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 8:24 [PATCH 0/2] x86: fix memory leaks when doing CPU hotplug Andreas Herrmann
2008-08-06 8:27 ` [PATCH 1/2] x86: pda_init(): fix memory leak when using " Andreas Herrmann
2008-08-06 8:29 ` [PATCH 2/2] x86: cpu_init(): " Andreas Herrmann
2008-08-11 19:40 ` [PATCH 0/2] x86: fix memory leaks when doing " Ingo Molnar
2008-09-02 7:14 ` Andreas Herrmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902071428.GA6743@alberich.amd.com \
--to=andreas.herrmann3@amd.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.