All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-scsi@vger.kernel.org, dougg@torque.net,
	michaelc@cs.wisc.edu, James.Bottomley@HansenPartnership.com,
	fujita.tomonori@lab.ntt.co.jpy
Subject: Re: [PATCH 0/2] older SG interface fixes (for the block layer conversion)
Date: Tue, 2 Sep 2008 09:31:26 +0200	[thread overview]
Message-ID: <20080902073125.GY20055@kernel.dk> (raw)
In-Reply-To: <1220340020-4855-1-git-send-email-fujita.tomonori@lab.ntt.co.jp>

On Tue, Sep 02 2008, FUJITA Tomonori wrote:
> I messed up the older SG interface's READ commands.
> 
> With READ commands via the older SG interface, we don't know a
> user-space address to transfer the result data when executing a SCSI
> command. So we can't pass a user-space address to blk_rq_map_user.
> 
> This changes blk_rq_map_user to takes a NULL user-space address. That
> is, sg uses blk_rq_map_user to just set up a request and bios with
> page frames without data transfer (similar to what scsi_req_map_sg
> does for sg now).
> 
> blk_rq_map_user doesn't map a user space address so the name,
> blk_rq_map_user, might be odd but I leave it alone.

Applied

-- 
Jens Axboe


      parent reply	other threads:[~2008-09-02  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-02  7:20 [PATCH 0/2] older SG interface fixes (for the block layer conversion) FUJITA Tomonori
2008-09-02  7:20 ` [PATCH 1/2] block: make blk_rq_map_user take a NULL user-space buffer FUJITA Tomonori
2008-09-02  7:20   ` [PATCH 2/2] sg: set dxferp to NULL for READ with the older SG interface FUJITA Tomonori
2008-09-02  7:31 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080902073125.GY20055@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dougg@torque.net \
    --cc=fujita.tomonori@lab.ntt.co.jpy \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.