From: Jarek Poplawski <jarkao2@gmail.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org, davem@davemloft.net,
Alexander Duyck <alexander.h.duyck@intel.com>
Subject: Re: [UPDATED] [NET-NEXT PATCH 2/2] pkt_action: add new action skbedit
Date: Tue, 2 Sep 2008 12:27:22 +0000 [thread overview]
Message-ID: <20080902122722.GA5040@ff.dom.local> (raw)
In-Reply-To: <20080830072338.7597.81426.stgit@jtkirshe-mobile.jf.intel.com>
On 30-08-2008 09:24, Jeff Kirsher wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This new action will have the ability to change the priority and/or
> queue_mapping fields on an sk_buff.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Two cosmetic suggestions:
Probably: include/linux/tc_act/Kbuild should be updated too.
> include/linux/tc_act/tc_skbedit.h | 23 ++++
> include/net/tc_act/tc_skbedit.h | 15 +++
> net/sched/Kconfig | 11 ++
> net/sched/Makefile | 1
> net/sched/act_skbedit.c | 200 +++++++++++++++++++++++++++++++++++++
...
> diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c
> new file mode 100644
> index 0000000..0bc4616
> --- /dev/null
> +++ b/net/sched/act_skbedit.c
...
> +#include <net/pkt_sched.h>
> +
> +#define TCA_ACT_SKBEDIT 11
Doesn't matter, but most of others (except act_simple) keep this TCA_
in include/linux/tc_act/tc_xyz.h.
Otherwise it looks OK to me.
Jarek P.
next prev parent reply other threads:[~2008-09-02 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-30 7:23 [UPDATED] [NET-NEXT PATCH 1/2] pkt_sched: Add multiqueue scheduler support Jeff Kirsher
2008-08-30 7:24 ` [UPDATED] [NET-NEXT PATCH 2/2] pkt_action: add new action skbedit Jeff Kirsher
2008-09-02 12:27 ` Jarek Poplawski [this message]
2008-09-01 21:05 ` [UPDATED] [NET-NEXT PATCH 1/2] pkt_sched: Add multiqueue scheduler support Jarek Poplawski
2008-09-01 22:49 ` Alexander Duyck
2008-09-02 5:54 ` Jarek Poplawski
2008-09-02 7:52 ` Jarek Poplawski
2008-09-02 17:18 ` Duyck, Alexander H
2008-09-02 20:09 ` Jarek Poplawski
2008-09-02 20:53 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902122722.GA5040@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.