From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KaW5t-0005v5-G3 for mharc-grub-devel@gnu.org; Tue, 02 Sep 2008 09:38:53 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KaW5s-0005uJ-4D for grub-devel@gnu.org; Tue, 02 Sep 2008 09:38:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KaW5p-0005tG-KI for grub-devel@gnu.org; Tue, 02 Sep 2008 09:38:51 -0400 Received: from [199.232.76.173] (port=49017 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaW5p-0005t5-D7 for grub-devel@gnu.org; Tue, 02 Sep 2008 09:38:49 -0400 Received: from aybabtu.com ([69.60.117.155]:43000) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KaW5o-0002Ae-S6 for grub-devel@gnu.org; Tue, 02 Sep 2008 09:38:49 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KaVvb-0006Qw-JR for grub-devel@gnu.org; Tue, 02 Sep 2008 15:28:15 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KaW4K-00087S-H8 for grub-devel@gnu.org; Tue, 02 Sep 2008 15:37:16 +0200 Date: Tue, 2 Sep 2008 15:37:16 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080902133716.GA31165@thorin> References: <489EEAC5.4080209@jejik.com> <1218471512.6939.19.camel@fz.local> <1218735245.8950.10.camel@fz.local> <20080814180353.GC5614@thorin> <1218742324.10393.8.camel@fz.local> <20080814203856.GA23307@thorin> <1218748505.10393.13.camel@fz.local> <1219071926.4569.57.camel@fz.local> <20080901221405.GA11511@thorin> <1220309171.4115.31.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1220309171.4115.31.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2008 13:38:52 -0000 On Tue, Sep 02, 2008 at 12:46:11AM +0200, Felix Zielcke wrote: > > I'm now not that sure if that #define k would be okay, seems like Vesa > isn't liking macros. If you use macros, please give them meaningful names. But a macro just for sizeof("foo") isn't much of an improvemtn, since the resulting code is the same, and it just makes it less readable. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."