From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KabSe-0001Ru-ND for mharc-grub-devel@gnu.org; Tue, 02 Sep 2008 15:22:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KabSc-0001Qj-KA for grub-devel@gnu.org; Tue, 02 Sep 2008 15:22:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KabSb-0001Q0-79 for grub-devel@gnu.org; Tue, 02 Sep 2008 15:22:42 -0400 Received: from [199.232.76.173] (port=33777 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KabSa-0001Pv-Oe for grub-devel@gnu.org; Tue, 02 Sep 2008 15:22:40 -0400 Received: from aybabtu.com ([69.60.117.155]:54907) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KabSa-0001zf-Az for grub-devel@gnu.org; Tue, 02 Sep 2008 15:22:40 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KabIP-0007j8-4j for grub-devel@gnu.org; Tue, 02 Sep 2008 21:12:09 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KabR9-0002OS-PU for grub-devel@gnu.org; Tue, 02 Sep 2008 21:21:11 +0200 Date: Tue, 2 Sep 2008 21:21:11 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080902192111.GB9070@thorin> References: <20080830122626.GA5899@thorin> <20080830114118.3zltziz18g0ss8ws-cebfxv@webmail.spamcop.net> <20080831133355.GC2688@thorin> <1220312369.21219.18.camel@dv> <20080902134045.GB31165@thorin> <87abeqlkjd.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87abeqlkjd.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix disk->id abuse X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2008 19:22:43 -0000 On Tue, Sep 02, 2008 at 03:55:18PM +0200, Marco Gerards wrote: > > [...] > > >> We could write a macro for ID comparison that would compare both the > >> "driver ID" (disk->dev->id) and "device ID" (disk->id). In this case, > >> we can omit disk->id initialization in the drivers supporting only one > >> device (e.g. memdisk) and only leave it where it's indeed needed for > >> identifying separate devices, thus removing potentially confusing code. > > > > Sounds fine, although what worries me most if the current usage of 'id' in > > scsi.c, which can lead to collision already. > > > > I assume using LUNs is a proper solution for that one? > > No, it is not. I think I already said so on IRC? If you did, I must have missed it. In any case, what can we use instead of that? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."