From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KabVp-00030E-Vk for mharc-grub-devel@gnu.org; Tue, 02 Sep 2008 15:26:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KabVo-0002xj-8E for grub-devel@gnu.org; Tue, 02 Sep 2008 15:26:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KabVn-0002wn-Bi for grub-devel@gnu.org; Tue, 02 Sep 2008 15:25:59 -0400 Received: from [199.232.76.173] (port=44919 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KabVn-0002wV-4F for grub-devel@gnu.org; Tue, 02 Sep 2008 15:25:59 -0400 Received: from aybabtu.com ([69.60.117.155]:44586) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KabVn-0003Gi-1i for grub-devel@gnu.org; Tue, 02 Sep 2008 15:25:59 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KabLX-0007jJ-2M for grub-devel@gnu.org; Tue, 02 Sep 2008 21:15:23 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KabUH-0002QL-PU for grub-devel@gnu.org; Tue, 02 Sep 2008 21:24:25 +0200 Date: Tue, 2 Sep 2008 21:24:25 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080902192425.GC9070@thorin> References: <20080830122626.GA5899@thorin> <20080830114118.3zltziz18g0ss8ws-cebfxv@webmail.spamcop.net> <20080831133355.GC2688@thorin> <1220312369.21219.18.camel@dv> <20080902134045.GB31165@thorin> <87abeqlkjd.fsf@xs4all.nl> <48BD9004.1030901@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48BD9004.1030901@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix disk->id abuse X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2008 19:26:00 -0000 On Tue, Sep 02, 2008 at 09:12:04PM +0200, Christian Franke wrote: > > If disk->id is supposed to be a GUID ('Grub Unique Identifier' in this > case :-), then a pointer to the private data structure for the disk > should work. This id is unique until disk close. > > For drivers without disk->data, simply use the address of e.g. the open > function itself. This is fine for single-disk drivers, but for multi-disk ones we need it to be unique among different disks provided by the same driver. Although, of course, I don't see why can't we just make it use a pointer to itself: disk->id = (unsigned long) &disk->id; but then what's the point of storing that in a variable anyway. We might as well just remove this variable and whoever uses it can use a pointer to the structure instead? This works on the assumption that disk structures are never reallocated, but I suppose that's a sane thing to assume... -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."