All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <me@felipebalbi.com>
To: "Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [RESEND][Review Request] Adding csi2_fck declaration to clock34xx.h
Date: Wed, 3 Sep 2008 01:37:52 +0300	[thread overview]
Message-ID: <20080902223749.GH6814@frodo> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE894411A0781F@dlee02.ent.ti.com>

On Tue, Sep 02, 2008 at 05:33:55PM -0500, Aguirre Rodriguez, Sergio Alberto wrote:
> +static struct clk csi2_96m_fck = {
> +        .name           = "csi2_96m_fck",
> +        .parent         = &core_96m_fck,
> +        .init           = &omap2_init_clk_clkdm,
> +        .enable_reg     = _OMAP34XX_CM_REGADDR(OMAP3430_CAM_MOD, CM_FCLKEN),
> +        .enable_bit     = OMAP3430_EN_CSI2_SHIFT,
> +        .flags          = CLOCK_IN_OMAP343X,
> +	.clkdm		= { .name = "cam_clkdm" },
> +        .recalc         = &followparent_recalc,
> +};

do not use spaces for identation, I think it's a mailer problem. Try to
use git send-email. Also, clkdm should be initialized as:

	.clkdm		= {
		.name	= "cam_clkdm",
	},

>  /* CM_FCLKEN_CAM specific bits */
> +#define OMAP3430_EN_CSI2				(1 << 1)
> +#define OMAP3430_EN_CSI2_SHIFT				1

align these with the rest of the file

-- 
balbi

  reply	other threads:[~2008-09-02 22:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-02 22:33 [RESEND][Review Request] Adding csi2_fck declaration to clock34xx.h Aguirre Rodriguez, Sergio Alberto
2008-09-02 22:37 ` Felipe Balbi [this message]
2008-09-02 23:03   ` Aguirre Rodriguez, Sergio Alberto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080902223749.GH6814@frodo \
    --to=me@felipebalbi.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=saaguirre@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.