From: Tony Lindgren <tony@atomide.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] fix arch/arm/plat-omap/gpio.c compilation
Date: Tue, 2 Sep 2008 15:48:00 -0700 [thread overview]
Message-ID: <20080902224759.GK23085@atomide.com> (raw)
In-Reply-To: <20080829092321.GG16462@cs181140183.pp.htv.fi>
* Adrian Bunk <bunk@kernel.org> [080829 02:24]:
> This patch fixes the following compile error:
>
> <-- snip -->
>
> ...
> CC arch/arm/plat-omap/gpio.o
> ...
> arch/arm/plat-omap/gpio.c: In function '_omap_gpio_init':
> arch/arm/plat-omap/gpio.c:1492: error: 'omap_mpuio_device' undeclared (first use in this function)
> arch/arm/plat-omap/gpio.c:1492: error: (Each undeclared identifier is reported only once
> arch/arm/plat-omap/gpio.c:1492: error: for each function it appears in.)
> make[2]: *** [arch/arm/plat-omap/gpio.o] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 3e76ee2..9e1341e 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -1488,7 +1488,7 @@ static int __init _omap_gpio_init(void)
> bank->chip.set = gpio_set;
> if (bank_is_mpuio(bank)) {
> bank->chip.label = "mpuio";
> -#ifdef CONFIG_ARCH_OMAP1
> +#ifdef CONFIG_ARCH_OMAP16XX
> bank->chip.dev = &omap_mpuio_device.dev;
> #endif
> bank->chip.base = OMAP_MPUIO(0);
>
Looks like a proper fix. BTW, this same fix is already in a patch from
Russell.
Tony
prev parent reply other threads:[~2008-09-02 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 9:23 [RFC: 2.6 patch] fix arch/arm/plat-omap/gpio.c compilation Adrian Bunk
2008-09-02 22:48 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902224759.GK23085@atomide.com \
--to=tony@atomide.com \
--cc=bunk@kernel.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.