From: Paul Mundt <lethal@linux-sh.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5132] SH4: fix a regression introduced in r5122
Date: Wed, 3 Sep 2008 13:23:58 +0900 [thread overview]
Message-ID: <20080903042358.GA5322@linux-sh.org> (raw)
In-Reply-To: <200809030101.17786.s@informa.pl>
On Wed, Sep 03, 2008 at 01:01:17AM +0200, Sebastian Kaliszewski wrote:
> Dnia Tuesday 02 of September 2008, Aurelien Jarno napisa??:
> > Revision: 5132
> > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5132
> > Author: aurel32
> > Date: 2008-09-02 08:42:16 +0000 (Tue, 02 Sep 2008)
> >
> > Log Message:
> > -----------
> > SH4: fix a regression introduced in r5122
> >
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> >
> > Modified Paths:
> > --------------
> > trunk/target-sh4/translate.c
> >
> > Modified: trunk/target-sh4/translate.c
> > ===================================================================
> > --- trunk/target-sh4/translate.c 2008-09-02 00:09:35 UTC (rev 5131)
> > +++ trunk/target-sh4/translate.c 2008-09-02 08:42:16 UTC (rev 5132)
> > @@ -1392,7 +1392,7 @@
> > tcg_gen_qemu_st32 (cpu_##reg, addr, ctx->memidx); \
> > tcg_temp_free(addr); \
> > tcg_gen_subi_i32(REG(B11_8), REG(B11_8), 4); \
> > - }
> > + } \
> > return;
> > LDST(gbr, 0x401e, 0x4017, 0x0012, 0x4013)
> > LDST(vbr, 0x402e, 0x4027, 0x0022, 0x4023)
>
> Hello!
>
> Hmm, this is just adding one space, are you sure the right thing go commited
>
Read again. It's adding a \ so the return; is factored in to the macro.
prev parent reply other threads:[~2008-09-03 4:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 8:42 [Qemu-devel] [5132] SH4: fix a regression introduced in r5122 Aurelien Jarno
2008-09-02 23:01 ` Sebastian Kaliszewski
2008-09-03 4:23 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080903042358.GA5322@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.