From: Michael Buesch <mb@bu3sch.de>
To: John Linville <linville@tuxdriver.com>
Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: [PATCH] b43: Replace hardcoded Analog switch
Date: Wed, 3 Sep 2008 12:31:54 +0200 [thread overview]
Message-ID: <200809031231.55338.mb@bu3sch.de> (raw)
Replace a hardcoded Analog switch (which breaks on N-PHY) by a call to
the switch_analog PHY operation.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
John, please queue for the next merge window.
Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/main.c 2008-09-03 11:58:23.000000000 +0200
+++ wireless-testing/drivers/net/wireless/b43/main.c 2008-09-03 12:27:03.000000000 +0200
@@ -2715,13 +2715,14 @@ static int b43_chip_init(struct b43_wlde
goto out; /* firmware is released later */
err = b43_upload_initvals(dev);
if (err)
goto err_gpio_clean;
- b43_write16(dev, 0x03E6, 0x0000);
+ /* Turn the Analog on and initialize the PHY. */
+ phy->ops->switch_analog(dev, 1);
err = b43_phy_init(dev);
if (err)
goto err_gpio_clean;
/* Disable Interference Mitigation. */
if (phy->ops->interf_mitigation)
reply other threads:[~2008-09-03 10:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809031231.55338.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.