From: Andrew Morton <akpm@linux-foundation.org>
To: Matt Mackall <mpm@selenic.com>
Cc: aaron@merfinllc.com, linux-kernel@vger.kernel.org, tytso@mit.edu,
stable@kernel.org
Subject: Re: drivers/char/random.c line 728 BUG
Date: Wed, 3 Sep 2008 15:32:06 -0700 [thread overview]
Message-ID: <20080903153206.24dc88c3.akpm@linux-foundation.org> (raw)
In-Reply-To: <1220479920.17608.62.camel@calx>
On Wed, 03 Sep 2008 17:12:00 -0500
Matt Mackall <mpm@selenic.com> wrote:
> > Could we still apply his patch for the upcoming stable tree and fix it
> > the "right" way at some point in the future?
>
> I'm not sure what the current state of play is here in terms of the
> original patch being pushed to stable and mainline, but my patch is both
> simpler and more correct. If it's not too late, it's the one that should
> go to both places.
It's a fairly minor thing. The post-this-patch code takes care to
ensure that ->entropy_count never has an illegal value, so it's OK but
aesthetially unpleasing to check its value outside the lock.
And the post-this-patch code generates less .text, so it's a desirable
thing from that POV too.
We could/should do both, I guess. I kinda ducked your move-the-BUG
patch because I wasn't in a write-yet-another-changelog mood.
next prev parent reply other threads:[~2008-09-03 22:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 22:59 drivers/char/random.c line 728 BUG Aaron Straus
2008-08-28 22:59 ` Aaron Straus
2008-08-29 19:48 ` Andrew Morton
2008-08-29 19:54 ` Andrew Morton
2008-08-29 22:31 ` Aaron Straus
2008-08-29 22:42 ` Andrew Morton
2008-09-03 18:18 ` Matt Mackall
2008-09-03 18:28 ` Aaron Straus
2008-09-03 22:12 ` Matt Mackall
2008-09-03 22:32 ` Andrew Morton [this message]
2008-09-03 22:51 ` Matt Mackall
2008-09-03 23:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080903153206.24dc88c3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aaron@merfinllc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=stable@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.