From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755933AbYICTNu (ORCPT ); Wed, 3 Sep 2008 15:13:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753430AbYICTNm (ORCPT ); Wed, 3 Sep 2008 15:13:42 -0400 Received: from one.firstfloor.org ([213.235.205.2]:55758 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753385AbYICTNl (ORCPT ); Wed, 3 Sep 2008 15:13:41 -0400 Date: Wed, 3 Sep 2008 21:16:51 +0200 From: Andi Kleen To: Andrew Morton Cc: Andi Kleen , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [1/2] Add a SYSTEM_PANIC state Message-ID: <20080903191650.GV18288@one.firstfloor.org> References: <20080902349.573187695@firstfloor.org> <20080902134922.9401F3E6A00@basil.firstfloor.org> <20080903120423.9e00557c.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080903120423.9e00557c.akpm@linux-foundation.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 03, 2008 at 12:04:23PM -0700, Andrew Morton wrote: > On Tue, 2 Sep 2008 15:49:22 +0200 (CEST) > Andi Kleen wrote: > > > --- linux.orig/include/linux/kernel.h > > +++ linux/include/linux/kernel.h > > @@ -248,6 +248,7 @@ extern enum system_states { > > SYSTEM_POWER_OFF, > > SYSTEM_RESTART, > > SYSTEM_SUSPEND_DISK, > > + SYSTEM_PANIC, > > } system_state; > > system_state is such a crock. I wonder what other random code all over > the place is looking at system_state and will get unexpectedly broken > by other "unrelated" changes such as this.. >>From a quick grep none. Also I think it's a natural extension. > > > It's not a heck of a lot nicer, but we could do this: Sorry but I think it's far worse. How do you think it's better? -Andi