From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: order functions in cpu/common.c and cpu/common_64.c
Date: Thu, 4 Sep 2008 21:37:33 +0200 [thread overview]
Message-ID: <20080904193733.GA25136@elte.hu> (raw)
In-Reply-To: <20080904191205.GC24990@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> applied these patches to tip/x86/cpu:
>
> 0a488a5: x86: move 32bit related functions together
> 01b2e16: x86: make get_mode_name of 64bit the same as 32bit
> a0854a4: x86: make 32bit support show_msr like 64 bit
> 10a434f: x86: remove cpu_vendor_dev
> 9d31d35: x86: order functions in cpu/common.c and cpu/common_64.c v2
> 3da99c9: x86: make (early)_identify_cpu more the same between 32bit and 64 bit
> 5031088: x86: delay early cpu initialization until cpuid is done
> 5fef55f: x86: move mtrr cpu cap setting early in early_init_xxxx
hm, something in your patch series is early-crashing tip/master with
this config:
http://redhat.com/~mingo/misc/config-Thu_Sep__4_21_23_20_CEST_2008.bad
the early-RIP is 0xffffffff804365b0:
ffffffff8043656a <proc_bus_pci_release>:
ffffffff804365b0: be d0 00 00 00 mov $0xd0,%esi
ffffffff804365b5: e8 ad 28 e7 ff callq ffffffff802a8e67 <kmem_cache_alloc>
fault 0xd, general protection fault. Given that it's an immediate
constant load, something really serious happened.
i've pushed out the broken tree into tip/tmp.master.broken (havent
updated tip/master with the breakage). I've removed the broken printk in
kernel/resource.c that Andrew found, see commit 06e44f6af324 - so that's
not the cause.
Ingo
next prev parent reply other threads:[~2008-09-04 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 5:05 [PATCH] x86: order functions in cpu/common.c and cpu/common_64.c Yinghai Lu
2008-09-04 19:12 ` Ingo Molnar
2008-09-04 19:37 ` Ingo Molnar [this message]
2008-09-04 19:41 ` Ingo Molnar
2008-09-04 19:59 ` Yinghai Lu
2008-09-04 20:04 ` Ingo Molnar
2008-09-04 20:07 ` Yinghai Lu
2008-09-04 20:32 ` Yinghai Lu
2008-09-04 20:37 ` Yinghai Lu
2008-09-04 20:58 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904193733.GA25136@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.