From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 1/2] OMAP2xxx EAC: update per recent IO address changes
Date: Fri, 5 Sep 2008 08:23:18 +0100 [thread overview]
Message-ID: <20080905072318.GA32345@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080905055048.5272.89989.stgit@localhost.localdomain>
On Thu, Sep 04, 2008 at 11:51:15PM -0600, Paul Walmsley wrote:
> @@ -707,7 +707,7 @@ static int __devinit eac_probe(struct platform_device *pdev)
> err = -ENODEV;
> goto err1;
> }
> - eac->base = (void __iomem *)io_p2v(res->start);
> + eac->base = ioremap(res->start, (res->end - res->start) + 1);
The parens around the subtraction are just noise; please remove.
next prev parent reply other threads:[~2008-09-05 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 5:50 [PATCH v2 0/2] OMAP2xxx EAC build fix and sparse cleanup Paul Walmsley
2008-09-05 5:51 ` [PATCH v2 1/2] OMAP2xxx EAC: update per recent IO address changes Paul Walmsley
2008-09-05 7:23 ` Russell King - ARM Linux [this message]
2008-09-05 5:51 ` [PATCH v2 2/2] OMAP2xxx EAC: fix sparse warnings Paul Walmsley
2008-09-05 7:00 ` [PATCH v2 0/2] OMAP2xxx EAC build fix and sparse cleanup Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905072318.GA32345@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.