All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <paul.moore@hp.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	netdev <netdev@vger.kernel.org>
Subject: Re: + security-selinux-include-netlabelh-fix-two-build-errors.patch added to -mm tree
Date: Fri, 5 Sep 2008 12:44:15 -0400	[thread overview]
Message-ID: <200809051244.15420.paul.moore@hp.com> (raw)
In-Reply-To: <20080904210033.20700500.randy.dunlap@oracle.com>

On Friday 05 September 2008 12:00:33 am Randy Dunlap wrote:
> Even with this patch, net/netlabel/netlabel_mgmt.c has build errors
> when CONFIG_IPV6=n:

Interesting, I tried to reproduce this quickly by changing my .config, 
running 'make oldconfig', verifying that CONFIG_IPV6 was still "n" (it 
was actually commented out), and then running 'make M=net/netlabel' ... 
the result was no error.

You are correct, I obviously made a mistake in the code (which I am 
fixing now) but I don't understand why the steps I took above didn't 
highlight the problem?  What am I missing?

> linux-next-20080904/net/netlabel/netlabel_domainhash.c:79: warning:
> unused variable 'tmp6'
> linux-next-20080904/net/netlabel/netlabel_domainhash.c:78: warning:
> unused variable 'iter6'
> linux-next-20080904/net/netlabel/netlabel_domainhash.c:340: warning:
> unused variable 'tmp6'
> linux-next-20080904/net/netlabel/netlabel_domainhash.c:301: warning:
> unused variable 'iter6'
> linux-next-20080904/net/netlabel/netlabel_mgmt.c:219: error: implicit
> declaration of function 'netlbl_af6list_add'
> linux-next-20080904/net/netlabel/netlabel_mgmt.c:317: error: implicit
> declaration of function 'netlbl_af6list_foreach_rcu'
> linux-next-20080904/net/netlabel/netlabel_mgmt.c:318: error: expected
> ';' before '{' token make[3]: *** [net/netlabel/netlabel_mgmt.o]
> Error 1

-- 
paul moore
linux @ hp

  parent reply	other threads:[~2008-09-05 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-05  3:26 + security-selinux-include-netlabelh-fix-two-build-errors.patch added to -mm tree akpm
2008-09-05  4:00 ` Randy Dunlap
2008-09-05 11:44   ` Paul Moore
2008-09-05 16:44   ` Paul Moore [this message]
2008-09-05 17:02     ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809051244.15420.paul.moore@hp.com \
    --to=paul.moore@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.