From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753896AbYIEVUx (ORCPT ); Fri, 5 Sep 2008 17:20:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751098AbYIEVUp (ORCPT ); Fri, 5 Sep 2008 17:20:45 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:32973 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbYIEVUo (ORCPT ); Fri, 5 Sep 2008 17:20:44 -0400 Date: Fri, 5 Sep 2008 14:20:40 -0700 From: Andrew Morton To: "Jan Beulich" Cc: linux-kernel@vger.kernel.org, Jesse Barnes Subject: Re: [PATCH] fix printk format compiler warnings Message-Id: <20080905142040.7497be38.akpm@linux-foundation.org> In-Reply-To: <48C13CE0.76E4.0078.0@novell.com> References: <48C13CE0.76E4.0078.0@novell.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Sep 2008 13:06:24 +0100 "Jan Beulich" wrote: > %llx and the like cannot be used on u64-derived data types - they must > be cast to long long explicitly for arch-es where u64 is a typedef of > unsigned long (ia64 is where I observed the problem). > > Signed-off-by: Jan Beulich > > --- > drivers/pci/probe.c | 16 +++++++++++++--- > drivers/pci/setup-bus.c | 6 +++++- > 2 files changed, 18 insertions(+), 4 deletions(-) > > --- linux-2.6.27-rc5/drivers/pci/probe.c 2008-08-21 14:37:32.000000000 +0200 > +++ 2.6.27-rc5-pci-probe-print/drivers/pci/probe.c 2008-09-02 15:18:08.000000000 +0200 > @@ -383,7 +383,10 @@ void __devinit pci_read_bridge_bases(str > res->start = base; > if (!res->end) > res->end = limit + 0xfff; > - printk(KERN_INFO "PCI: bridge %s io port: [%llx, %llx]\n", pci_name(dev), res->start, res->end); > + printk(KERN_INFO "PCI: bridge %s io port: [%Lx, %Lx]\n", > + pci_name(dev), > + (unsigned long long)res->start, > + (unsigned long long)res->end); > } > > res = child->resource[1]; > @@ -395,7 +398,10 @@ void __devinit pci_read_bridge_bases(str > res->flags = (mem_base_lo & PCI_MEMORY_RANGE_TYPE_MASK) | IORESOURCE_MEM; > res->start = base; > res->end = limit + 0xfffff; > - printk(KERN_INFO "PCI: bridge %s 32bit mmio: [%llx, %llx]\n", pci_name(dev), res->start, res->end); > + printk(KERN_INFO "PCI: bridge %s 32bit mmio: [%Lx, %Lx]\n", > + pci_name(dev), > + (unsigned long long)res->start, > + (unsigned long long)res->end); > } > > res = child->resource[2]; > @@ -431,7 +437,11 @@ void __devinit pci_read_bridge_bases(str > res->flags = (mem_base_lo & PCI_MEMORY_RANGE_TYPE_MASK) | IORESOURCE_MEM | IORESOURCE_PREFETCH; > res->start = base; > res->end = limit + 0xfffff; > - printk(KERN_INFO "PCI: bridge %s %sbit mmio pref: [%llx, %llx]\n", pci_name(dev), (res->flags & PCI_PREF_RANGE_TYPE_64)?"64":"32",res->start, res->end); > + printk(KERN_INFO "PCI: bridge %s %dbit mmio pref: [%Lx, %Lx]\n", > + pci_name(dev), > + res->flags & PCI_PREF_RANGE_TYPE_64 ? 64 : 32, > + (unsigned long long)res->start, > + (unsigned long long)res->end); > } > } > > --- linux-2.6.27-rc5/drivers/pci/setup-bus.c 2008-08-21 14:37:32.000000000 +0200 > +++ 2.6.27-rc5-pci-probe-print/drivers/pci/setup-bus.c 2008-09-02 15:18:20.000000000 +0200 > @@ -539,7 +539,11 @@ static void pci_bus_dump_res(struct pci_ > if (!res) > continue; > > - printk(KERN_INFO "bus: %02x index %x %s: [%llx, %llx]\n", bus->number, i, (res->flags & IORESOURCE_IO)? "io port":"mmio", res->start, res->end); > + printk(KERN_INFO "bus: %02x index %x %s: [%Lx, %Lx]\n", > + bus->number, i, > + res->flags & IORESOURCE_IO ? "io port" : "mmio", > + (unsigned long long)res->start, > + (unsigned long long)res->end); > } > } > > These have been fixed in linux-next for a month. Jesse, can we get that into 2.6.27 please?