From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Kbees-0002u4-GA for mharc-grub-devel@gnu.org; Fri, 05 Sep 2008 12:59:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kbeeq-0002sd-Qm for grub-devel@gnu.org; Fri, 05 Sep 2008 12:59:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kbeeo-0002rd-Ip for grub-devel@gnu.org; Fri, 05 Sep 2008 12:59:40 -0400 Received: from [199.232.76.173] (port=37075 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kbeeo-0002rT-Ea for grub-devel@gnu.org; Fri, 05 Sep 2008 12:59:38 -0400 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:51874 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kbeen-0005DM-BH for grub-devel@gnu.org; Fri, 05 Sep 2008 12:59:37 -0400 Received: from pinux (5.60.221.87.dynamic.jazztel.es [87.221.60.5]) by mail.pina.cat (Postfix) with ESMTP id DCB8B2890653C for ; Fri, 5 Sep 2008 18:59:33 +0200 (CEST) Received: by pinux (Postfix, from userid 1000) id BF62E801B; Fri, 5 Sep 2008 18:59:32 +0200 (CEST) Date: Fri, 5 Sep 2008 18:59:32 +0200 From: Carles Pina i Estany To: The development of GRUB 2 Message-ID: <20080905165932.GC5625@pina.cat> References: <20080823144313.GA24757@pina.cat> <20080830114315.GC16775@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080830114315.GC16775@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Warning if grub.cfg not found X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Sep 2008 16:59:41 -0000 Hi, On Aug/30/2008, Robert Millan wrote: > > Hi > > On Sat, Aug 23, 2008 at 04:43:14PM +0200, Carles Pina i Estany wrote: > > Index: normal/cmdline.c > > =================================================================== > > --- normal/cmdline.c (revision 1826) > > +++ normal/cmdline.c (working copy) > > @@ -137,12 +137,17 @@ grub_cmdline_run (int nested) > > { > > grub_normal_init_page (); > > grub_setcursor (1); > > + > > + if ( nested == -1 ) > > nested was intended to be a "boolean"; this changes its meaning, so the name > becomes confusing. I think there's no need to reuse the variable in this part > of GRUB, and it'd be fine to add a new one IMO. However ... Ok, I will change in this way that you suggest. Thanks > > + grub_printf ("\n\ > > + WARNING: GNU GRUB couldn't open /boot/grub/grub.cfg\n\ > > + Falling back to GNU GRUB Command Line\n\n"); > > ... this looks like something that belongs whereever the decision to fall > back is taken. Then once the problem is handled there, you don't need to > tell the lower layer whether to print a message or not. I think that you mean that this message should be showed before it goes to command line layer? But i think that the command line layer cleans the screen, so anyway have to know something (or change and avoid cleaning the screen). Anyway, I will check it more deep next days. > > Also, I think there are two separate cases: > > - grub.cfg is there but can't be opened (we need to tell the user about > _why_ via grub_print_error()). > - grub.cfg is simply not there (perhaps the user intended that). > > and the messages should be somewhat different for each one. Ok, I understand this part I sent this patch on 23th August, you replied on 30th August and me again on 5th September. I think that until mid of next week I will a bit too busy to do it, but I haven't forgot :-) Thanks for the suggestions, -- Carles Pina i Estany GPG id: 0x17756391 http://pinux.info