From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Kbefa-0003TR-Ss for mharc-grub-devel@gnu.org; Fri, 05 Sep 2008 13:00:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KbefZ-0003SX-2I for grub-devel@gnu.org; Fri, 05 Sep 2008 13:00:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KbefY-0003Rp-69 for grub-devel@gnu.org; Fri, 05 Sep 2008 13:00:24 -0400 Received: from [199.232.76.173] (port=37111 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbefX-0003Rd-Uc for grub-devel@gnu.org; Fri, 05 Sep 2008 13:00:24 -0400 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:51881 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KbefV-0005W7-MO for grub-devel@gnu.org; Fri, 05 Sep 2008 13:00:22 -0400 Received: from pinux (5.60.221.87.dynamic.jazztel.es [87.221.60.5]) by mail.pina.cat (Postfix) with ESMTP id A866D2890653C for ; Fri, 5 Sep 2008 19:00:20 +0200 (CEST) Received: by pinux (Postfix, from userid 1000) id 86EC214664; Fri, 5 Sep 2008 19:00:19 +0200 (CEST) Date: Fri, 5 Sep 2008 19:00:19 +0200 From: Carles Pina i Estany To: The development of GRUB 2 Message-ID: <20080905170019.GD5625@pina.cat> References: <20080824130216.GA5808@pina.cat> <20080824142944.GA9470@pina.cat> <20080830115005.GE16775@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080830115005.GE16775@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Sep 2008 17:00:25 -0000 Hi, On Aug/30/2008, Robert Millan wrote: > On Sun, Aug 24, 2008 at 04:29:44PM +0200, Carles Pina i Estany wrote: > > > > Hi, > > > > I was just thinking now... > > > > On Aug/24/2008, Carles Pina i Estany wrote: > > > > > * include/grub/powerpc/ieee1275/console.h (GRUB_TERM_NPAGE): > > > Changed to 0x5100. > > > (GRUB_TERM_PPAGE): Changed to 0x4900. > > > > > > * include/grub/sparc64/ieee1275/console.h: Likewise. > > > > > > * include/grub/i386/pc/console.h: Likewise. > > > > > > * include/grub/efi/console.h: Likewise. > > > > I was just thinking... is there any reason that we have the same macros > > in 4 different files? > > This would need to be checked carefully, but a quick peek at > GRUB_CONSOLE_KEY_LEFT: > > ./kern/i386/pc/startup.S: .word GRUB_CONSOLE_KEY_LEFT, GRUB_TERM_LEFT > ./include/grub/i386/pc/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00 > ./include/grub/efi/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00 > ./include/grub/powerpc/ieee1275/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00 > ./include/grub/sparc64/ieee1275/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00 > > seems to indicate these macros are part of the BIOS console interface, > and therefore only used on i386-pc. > > If you can confirm this, I'd recommend just removing them from the other > console.h files. I will also check it and confirm (or not confirm). I will do it on next days. -- Carles Pina i Estany GPG id: 0x17756391 http://pinux.info