Re: [PATCH 22/33] add omap nand drivers

[Tony Lindgren <tony@atomide.com>]

* Felipe Balbi <me@felipebalbi.com> [080831 14:29]:
> On Sun, Aug 31, 2008 at 02:08:18PM -0700, David Brownell wrote:
> > Hmm, this seems like three distinct drivers to me.
> > Which should mean three separate patches ... going
> > go the MTD list!
> > 
> > 
> > On Saturday 30 August 2008, Felipe Balbi wrote:
> > > 
> > > +config MTD_NAND_OMAP2
> > > +       tristate "NAND Flash device on OMAP2 and OMAP3"
> > > +       depends on ARM && MTD_NAND && (ARCH_OMAP2 || ARCH_OMAP3)
> > > +       help
> > > +          Support for NAND flash on Texas Instruments OMAP2 and OMAP3 platforms.
> > 
> > I've got a small patch for this one which I'll post.
> 
> Great, I can meld it on the final version of the driver. Thanks
> 
> > > +config MTD_NAND_OMAP
> > > +       tristate "NAND Flash device on OMAP H3/H2/P2 boards"
> > > +       depends on ARM && ARCH_OMAP1 && MTD_NAND && (MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_PERSEUS2)
> > > +       help
> > > +         Support for NAND flash on Texas Instruments H3/H2/P2 platforms.
> > > +
> > > +config MTD_NAND_OMAP_HW
> > > +       bool "OMAP HW NAND Flash controller support"
> > > +        depends on ARM && ARCH_OMAP16XX && MTD_NAND
> > > +
> > > +       help
> > > +         Driver for TI OMAP16xx hardware NAND flash controller.
> > 
> > This one raises the question:  why are there *TWO* drivers for
> > the same hardware?  Which one is the failed experiment?
> 
> It's even worse. If you look at the Makefile itself, there are three:
> 
> obj-$(CONFIG_MTD_NAND_OMAP) 		+= omap-nand-flash.o
> obj-$(CONFIG_MTD_NAND_OMAP2) 		+= omap2.o
> obj-$(CONFIG_MTD_NAND_OMAP_HW)		+= omap-hw.o
> 
> Looks like this series was good for finding some weird stuff on
> linux-omap ;-)

Then there's also the MTD_NAND_TOTO.. Sure there were various NAND
controllers, but if some of them are no longer maintained, we should
just export them into patches and remove from kernel.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html