From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 1/3] mac80211: move some RCU locking into an if branch
Date: Mon, 08 Sep 2008 11:05:08 +0200 [thread overview]
Message-ID: <20080908090633.843025000@sipsolutions.net> (raw)
In-Reply-To: 20080908090507.641740000@sipsolutions.net
The if itself doesn't need to be protected, so move in the RCU
locking to avoid doing anything at all when the condition isn't
true.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/mlme.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
--- everything.orig/net/mac80211/mlme.c 2008-09-08 10:20:25.000000000 +0200
+++ everything/net/mac80211/mlme.c 2008-09-08 10:21:09.000000000 +0200
@@ -2613,13 +2613,12 @@ static void ieee80211_rx_bss_info(struct
mesh_peer_accepts_plinks(elems));
}
- rcu_read_lock();
-
if (sdata->vif.type == IEEE80211_IF_TYPE_IBSS && elems->supp_rates &&
memcmp(mgmt->bssid, sdata->u.sta.bssid, ETH_ALEN) == 0) {
-
supp_rates = ieee80211_sta_get_rates(local, elems, band);
+ rcu_read_lock();
+
sta = sta_info_get(local, mgmt->sa);
if (sta) {
u64 prev_rates;
@@ -2643,9 +2642,9 @@ static void ieee80211_rx_bss_info(struct
ieee80211_ibss_add_sta(sdata, NULL, mgmt->bssid,
mgmt->sa, supp_rates);
}
- }
- rcu_read_unlock();
+ rcu_read_unlock();
+ }
if (elems->ds_params && elems->ds_params_len == 1)
freq = ieee80211_channel_to_frequency(elems->ds_params[0]);
--
next prev parent reply other threads:[~2008-09-08 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 9:05 [PATCH 0/3] small mac80211 updates Johannes Berg
2008-09-08 9:05 ` Johannes Berg [this message]
2008-09-08 9:05 ` [PATCH 2/3] mac80211: make conf_tx non-atomic Johannes Berg
2008-09-08 9:05 ` [PATCH 3/3] mac80211: BSS info: check channel first Johannes Berg
2008-09-08 13:41 ` [PATCH 4/3] mac80211: fix action frame length checks Johannes Berg
2008-09-08 14:31 ` [PATCH 5/3] mac80211: fix typo in action frame handling Johannes Berg
2008-09-08 20:58 ` Tomas Winkler
2008-09-09 6:30 ` Johannes Berg
2008-09-08 14:40 ` [PATCH 6/3] mac80211: move IE parsing to util file Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080908090633.843025000@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.