From: Abhijit Menon-Sen <ams@toroid.org>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: Eric Wong <normalperson@yhbt.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t/t91XX-svn: start removing use of "git-" from these tests
Date: Mon, 8 Sep 2008 15:46:31 +0530 [thread overview]
Message-ID: <20080908101631.GA6948@toroid.org> (raw)
In-Reply-To: <20080908190205.6117@nanako3.lavabit.com>
At 2008-09-08 19:02:05 +0900, nanako3@lavabit.com wrote:
>
> This first step replaces literal strings "remotes/git-svn" and
> "git-svn-id" by introducing $remotes_git_svn and $git_svn_id
> constants defined as shell variables.
I'm sorry, but... why? I don't see the point at all. These are not even
commands; and, as someone who was just reading the svn tests, the change
certainly doesn't make them *easier* to follow.
-- ams
next prev parent reply other threads:[~2008-09-08 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 10:02 [PATCH] t/t91XX-svn: start removing use of "git-" from these tests Nanako Shiraishi
2008-09-08 10:16 ` Abhijit Menon-Sen [this message]
2008-09-08 10:27 ` Eric Wong
2008-09-09 2:23 ` Abhijit Menon-Sen
2008-09-09 8:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080908101631.GA6948@toroid.org \
--to=ams@toroid.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@lavabit.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.