From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KciOJ-0002xb-IP for mharc-grub-devel@gnu.org; Mon, 08 Sep 2008 11:10:59 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KciOH-0002x6-VP for grub-devel@gnu.org; Mon, 08 Sep 2008 11:10:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KciOG-0002wO-JU for grub-devel@gnu.org; Mon, 08 Sep 2008 11:10:57 -0400 Received: from [199.232.76.173] (port=52830 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KciOG-0002wI-8B for grub-devel@gnu.org; Mon, 08 Sep 2008 11:10:56 -0400 Received: from aybabtu.com ([69.60.117.155]:57910) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KciOF-0004AZ-Sr for grub-devel@gnu.org; Mon, 08 Sep 2008 11:10:56 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KciDS-0000jU-1Y for grub-devel@gnu.org; Mon, 08 Sep 2008 16:59:46 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KciMi-0006Xn-Tm for grub-devel@gnu.org; Mon, 08 Sep 2008 17:09:20 +0200 Date: Mon, 8 Sep 2008 17:09:20 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080908150920.GA24943@thorin> References: <20080908134723.GA22051@thorin> <20080908104902.o5gbh1bm2o8cssgs-cebfxv@webmail.spamcop.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080908104902.o5gbh1bm2o8cssgs-cebfxv@webmail.spamcop.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Move normal, serial & pci to i386.rmk X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2008 15:10:58 -0000 On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote: > Quoting Robert Millan : > > > > >This patch moves normal, serial and pci to conf/i386.rmk. > > Why i386? That code is not i386 specific. It is. Notice it's being moved from conf/i386-*.rmk, not common.rmk. normal: Includes normal/i386/setjmp.S serial, pci: Relies on grub_{in,out}{b,w,l} functions, which are only implemented for i386 so far. Of course, if someone writes the powerpc stubs, then they could be moved to common.rmk, but they're i386-specific now. > I believe we could declare SPARC broken, but keep PowerPC working. Agreed. I suggest we remove the conf/sparc* files, which are burdensome (since people unaware that SPARC is broken might try to keep them uptodate) and don't really provide any hard-to-find knowledge, and keep the kern/*/sparc/* bits which might be useful if/when someone tries to reinstate the port. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."