From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KclXs-0003Ok-6X for mharc-grub-devel@gnu.org; Mon, 08 Sep 2008 14:33:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KclXp-0003Nf-Sa for grub-devel@gnu.org; Mon, 08 Sep 2008 14:33:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KclXn-0003M8-Sg for grub-devel@gnu.org; Mon, 08 Sep 2008 14:33:00 -0400 Received: from [199.232.76.173] (port=37309 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KclXn-0003Lz-4Q for grub-devel@gnu.org; Mon, 08 Sep 2008 14:32:59 -0400 Received: from aybabtu.com ([69.60.117.155]:60219) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KclXm-0008Vo-8F for grub-devel@gnu.org; Mon, 08 Sep 2008 14:32:58 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KclMx-0001Sl-Iz for grub-devel@gnu.org; Mon, 08 Sep 2008 20:21:48 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KclWB-0008Az-HN for grub-devel@gnu.org; Mon, 08 Sep 2008 20:31:19 +0200 Date: Mon, 8 Sep 2008 20:31:19 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080908183119.GC31031@thorin> References: <48BED2B2.1060000@gmail.com> <20080904194015.GF9133@thorin> <48C05923.3060001@gmail.com> <20080908133815.GA21754@thorin> <48C56E79.9080502@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48C56E79.9080502@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Multiple partition maps X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2008 18:33:02 -0000 On Mon, Sep 08, 2008 at 08:27:05PM +0200, phcoder wrote: > Robert Millan wrote: > > On Thu, Sep 04, 2008 at 11:54:43PM +0200, phcoder wrote: > >> BTW GPT module checks the protective MBR. In some cases when legay OS > >> modified the MBR it's no longer "protective MBR". And in theese cases > >> GRUB will refuse to boot. Isn't the magic number check enough? > > > > If there's at least one protective GPT partition (0xee), I think this should > > be considered enough to accept the partmap as GPT. > > > In GPT module if first partition is not of type 0xee then it's > considered that no GPT is present. Is think that this check is > error-prone (with e.g. bootcamp) and unnecessary Agreed. Can you fix this? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."