diff for duplicates of <200809082017.24152.david-b@pacbell.net> diff --git a/a/1.txt b/N1/1.txt index 574379a..13ede7a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,8 @@ On Monday 08 September 2008, David Miller wrote: ->=20 +> > > > int update_persistent_clock(struct timespec now) > > > { -> > > =A0=A0=A0=A0struct rtc_device *rtc =3D rtc_class_open("rtc0"); +> > > struct rtc_device *rtc = rtc_class_open("rtc0"); One more point: that should probably use CONFIG_RTC_HCTOSYS_DEVICE instead of hard-wiring to "rtc0". Yeah, I'm sure your SPARCs have @@ -10,10 +10,10 @@ lots of RTCs to choose from -- not! -- but I'd like to see you end up with code that many folk can reuse/recycle/pirate. ;) -> >=20 +> > > > I'd be tempted to cache that ... notice how you never -> > close it, too. =A0That will goof lots of refcounts... ->=20 +> > close it, too. That will goof lots of refcounts... +> > Well if I cache it then we'll hold it forever and that's not > so nice right? @@ -25,7 +25,7 @@ exclusive operation. > I'm going to put the missing rtc_close() in there for now to > fix the leak. ->=20 +> > I'm happy to cache this if you think it's warranted, but then > this is like saying that the refcount doesn't matter :-) @@ -40,8 +40,3 @@ is cached and then try to get an RTC. Maybe it's available again; maybe not. - Dave --- -To unsubscribe from this list: send the line "unsubscribe linux-parisc"= - in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 40f65cd..1cd3213 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -14,10 +14,10 @@ "\00:1\0" "b\0" "On Monday 08 September 2008, David Miller wrote:\n" - ">=20\n" + "> \n" "> > > int update_persistent_clock(struct timespec now)\n" "> > > {\n" - "> > > =A0=A0=A0=A0struct rtc_device *rtc =3D rtc_class_open(\"rtc0\");\n" + "> > > \302\240\302\240\302\240\302\240struct rtc_device *rtc = rtc_class_open(\"rtc0\");\n" "\n" "One more point: that should probably use CONFIG_RTC_HCTOSYS_DEVICE\n" "instead of hard-wiring to \"rtc0\". Yeah, I'm sure your SPARCs have\n" @@ -25,10 +25,10 @@ "up with code that many folk can reuse/recycle/pirate. ;)\n" "\n" "\n" - "> >=20\n" + "> > \n" "> > I'd be tempted to cache that ... notice how you never\n" - "> > close it, too. =A0That will goof lots of refcounts...\n" - ">=20\n" + "> > close it, too. \302\240That will goof lots of refcounts...\n" + "> \n" "> Well if I cache it then we'll hold it forever and that's not\n" "> so nice right?\n" "\n" @@ -40,7 +40,7 @@ "\n" "> I'm going to put the missing rtc_close() in there for now to\n" "> fix the leak.\n" - ">=20\n" + "> \n" "> I'm happy to cache this if you think it's warranted, but then\n" "> this is like saying that the refcount doesn't matter :-)\n" "\n" @@ -54,11 +54,6 @@ "is cached and then try to get an RTC. Maybe it's available\n" "again; maybe not.\n" "\n" - "- Dave\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-parisc\"=\n" - " in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + - Dave -08479f2cb3b980cd5e65ea1c67e8e335bb03d9f4a32a2374a6cad972c7e3f620 +9feb946c9612910f14e04255efbc01aec2277536c1fb64aac13c49a00494f528
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.