From: Tony Lindgren <tony@atomide.com>
To: Steve Sakoman <sakoman@gmail.com>
Cc: linux-omap@vger.kernel.org, alsa-devel@alsa-project.org,
Steve Sakoman <steve@sakoman.com>
Subject: Re: [alsa-devel] [PATCH 3/5] ALSA: ASoC: Add support for TWL4030 audio codec (rev 3)
Date: Mon, 8 Sep 2008 17:49:46 -0700 [thread overview]
Message-ID: <20080909004945.GK29054@atomide.com> (raw)
In-Reply-To: <5e088bd90809081116v58ff6b14rd2331e5fccaeb097@mail.gmail.com>
* Steve Sakoman <sakoman@gmail.com> [080908 11:16]:
> On Mon, Sep 8, 2008 at 2:56 AM, Mark Brown <broonie@sirena.org.uk> wrote:
> > On Sat, Sep 06, 2008 at 11:41:42PM -0700, sakoman@gmail.com wrote:
> >
> >> +
> >> +config SND_SOC_TWL4030
> >> + tristate
> >> + depends on SND_SOC && I2C
> >> +
> >
> > Sorry, didn't notice earlier: this should depend on whatever the config
> > option is for the TWL4030 core driver rather than on I2C since it
> > doesn't actually interact with I2C directly. Although in most
> > applications this won't make much odds since the machine driver will
> > select the codec driver and select ignores the dependencies anyway.
>
> You are correct. Good catch, though as you say it doesn't really
> matter in practice.
>
> I will re-submit a version with this fixed nonetheless.
Pushing this series to linux-omap today with the re-submitted version
of patch 3/5.
Tony
prev parent reply other threads:[~2008-09-09 0:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 6:41 [PATCH 0/5] ARM: OMAP2: Add support for GUmstix Overo (rev 3) sakoman
2008-09-07 6:41 ` [PATCH 1/5] ARM: OMAP2: Add support for the Gumstix Overo board " sakoman
2008-09-07 6:41 ` [PATCH 2/5] ARM: OMAP2: Add video driver " sakoman
2008-09-07 6:41 ` [PATCH 3/5] ALSA: ASoC: Add support for TWL4030 audio codec " sakoman
2008-09-07 6:41 ` [PATCH 4/5] ALSA: ASoC: Add support for Gumstix Overo " sakoman
2008-09-07 6:41 ` [PATCH 5/5] ARM: OMAP2: defconfig for the Gumstix Overo board " sakoman
2008-09-08 9:56 ` [alsa-devel] [PATCH 3/5] ALSA: ASoC: Add support for TWL4030 audio codec " Mark Brown
2008-09-08 18:16 ` Steve Sakoman
2008-09-09 0:49 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909004945.GK29054@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=sakoman@gmail.com \
--cc=steve@sakoman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.