From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: David Miller <davem@davemloft.net>,
rdenis@simphalempin.com, akpm@linux-foundation.org,
netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bugme-new] [Bug 11469] New: TUN with 1024 neighbours: ip6_dst_lookup_tail NULL crash
Date: Tue, 9 Sep 2008 18:31:05 +0400 [thread overview]
Message-ID: <20080909143105.GA24239@2ka.mipt.ru> (raw)
In-Reply-To: <20080909113215.GB5991@hmsreliant.think-freely.org>
Hi.
On Tue, Sep 09, 2008 at 07:32:15AM -0400, Neil Horman (nhorman@tuxdriver.com) wrote:
> + /*
> + * Here if the dst entry we've looked up
> + * has a neighbour entry that is in the INCOMPLETE
> + * state and the src address from the flow is
> + * marked as OPTIMISTIC, we release the found
> + * dst entry and replace it instead with the
> + * dst entry of the nexthop router
> + */
> + if (dst->neighbour && !((*dst)->neighbour->nud_state & NUD_VALID)) {
^^^
This should be (*dst)->neighbour, isn't it?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-09-09 14:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-11469-10286@http.bugzilla.kernel.org/>
2008-08-31 18:13 ` [Bugme-new] [Bug 11469] New: TUN with 1024 neighbours: ip6_dst_lookup_tail NULL crash Andrew Morton
2008-09-05 11:41 ` Evgeniy Polyakov
2008-09-05 16:03 ` Rémi Denis-Courmont
2008-09-05 16:37 ` Evgeniy Polyakov
2008-09-07 18:11 ` Evgeniy Polyakov
2008-09-07 18:19 ` Rémi Denis-Courmont
2008-09-08 20:15 ` David Miller
2008-09-08 20:34 ` Evgeniy Polyakov
2008-09-09 10:56 ` Neil Horman
2008-09-09 11:32 ` Neil Horman
2008-09-09 14:31 ` Evgeniy Polyakov [this message]
2008-09-09 15:39 ` Neil Horman
2008-09-09 20:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909143105.GA24239@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rdenis@simphalempin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.