All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Nick Piggin <npiggin@suse.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] x86: some lock annotations for user copy paths
Date: Wed, 10 Sep 2008 14:12:17 +0200	[thread overview]
Message-ID: <20080910121217.GA16013@elte.hu> (raw)
In-Reply-To: <20080910114755.GA9696@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> > shouldn't some of that be conditional on pagefault_disable() 'n 
> > such?
> 
> i dont think so - those have their own special __atomic user-copy 
> primitives which Nick didnt touch.

hm, but the prefetch bits were touched, and -tip testing stumbled upon 
this false positive:

[   66.187448] PM: Adding info for No Bus:vcsa12
[   67.138685] evbug.c: Event. Dev: input0, Type: 20, Code: 0, Value: 500
[   80.149087] BUG: sleeping function called from invalid context at arch/x86/mm/fault.c:122
[   80.157344] in_atomic(): 1, irqs_disabled(): 0, pid: 6811, name: gam_server
[   80.164315] no locks held by gam_server/6811.
[   80.168685] Pid: 6811, comm: gam_server Not tainted 2.6.27-rc6-tip-00187-gbfd4ed7-dirty #2
[   80.177013] Call Trace:
[   80.179454]  [<ffffffff8026c1e8>] ? __debug_show_held_locks+0x22/0x24
[   80.185876]  [<ffffffff80242c4d>] __might_sleep+0x104/0x109
[   80.191430]  [<ffffffff8022fd25>] is_prefetch+0xe8/0x228
[   80.196760]  [<ffffffff8023050b>] do_page_fault+0x5d8/0x9a9
[   80.202361]  [<ffffffff802c8218>] ? sys_newstat+0x36/0x41
[   80.207774]  [<ffffffff80c3b2fa>] error_exit+0x0/0xb9

so i've excluded these commits for now. (once there's a fix i can 
continue testing it)

	Ingo

  parent reply	other threads:[~2008-09-10 12:12 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10 11:37 [patch] x86: some lock annotations for user copy paths Nick Piggin
2008-09-10 11:41 ` Peter Zijlstra
2008-09-10 11:47   ` Ingo Molnar
2008-09-10 11:50     ` Ingo Molnar
2008-09-10 12:12     ` Ingo Molnar [this message]
2008-09-10 12:32       ` Ingo Molnar
2008-09-10 15:12         ` Nick Piggin
2008-09-10 14:48       ` Nick Piggin
2008-09-10 15:01         ` Peter Zijlstra
2008-09-10 15:17           ` Nick Piggin
2008-09-10 15:26           ` Nick Piggin
2008-09-11  8:27             ` Ingo Molnar
2008-09-11 10:43               ` Nick Piggin
2008-09-12  9:24                 ` [PATCH] sysfs: fix deadlock Ingo Molnar
2008-09-14 22:02                   ` Nick Piggin
2008-09-15  9:15                     ` Peter Zijlstra
2008-09-14  7:39               ` [lockdep] possible circular locking, between &mm->mmap_sem and &dev->ev_mutex Ingo Molnar
2008-09-14  7:44                 ` Andrew Morton
2008-09-14  8:06                   ` [patch] mm: fix locking, inotify_read's ev_mutex vs do_page_fault's mmap_sem Ingo Molnar
2008-09-14 22:12                     ` [patch] mm: tiny-shmem fix lor, mmap_sem vs i_mutex Nick Piggin
2008-09-17 20:14                       ` Andrew Morton
2008-09-17 20:46                         ` Matt Mackall
2008-09-18 11:12                         ` Ingo Molnar
2008-09-18 19:29                           ` Jeremy Fitzhardinge
2008-09-18 21:11                             ` Matt Mackall
2008-09-20  2:18                               ` Dave Hansen
2008-09-20 16:12                                 ` Hugh Dickins
2008-09-22 14:54                                   ` David Howells
2008-09-23  5:32                                     ` Nick Piggin
2008-09-24 18:18                                       ` David Howells
2008-09-24 18:29                                         ` Matt Mackall
2008-09-24 18:56                                           ` David Howells
2008-09-24 19:11                                             ` Matt Mackall
2008-09-24 19:26                                               ` David Howells
2008-09-24 19:41                                           ` Hugh Dickins
2008-09-24 19:59                                             ` David Howells
2008-09-24 23:43                                               ` Hugh Dickins
2008-09-24 19:29                                       ` Hugh Dickins
2008-09-24 19:47                                         ` Andrew Morton
2008-09-22 15:14                                   ` Dave Hansen
2008-09-19  8:40                             ` Ingo Molnar
2008-09-14 21:36                   ` [lockdep] possible circular locking, between &mm->mmap_sem and &dev->ev_mutex Nick Piggin
2008-09-10 14:30     ` [patch] x86: some lock annotations for user copy paths Nick Piggin
2008-09-10 14:31 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080910121217.GA16013@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.