From: Andrew Morton <akpm@linux-foundation.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate
Date: Thu, 11 Sep 2008 00:03:27 +0000 [thread overview]
Message-ID: <20080910170327.a332ee30.akpm@linux-foundation.org> (raw)
In-Reply-To: <48C79487.1010105@gmail.com>
On Wed, 10 Sep 2008 03:47:32 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:
> +static ssize_t show_in_min_alarm(struct device *dev, struct device_attribute
> + *devattr, char *buf)
> +{
> + struct pc87360_data *data = pc87360_update_device(dev);
> + unsigned nr = to_sensor_dev_attr(devattr)->index;
> +
> + return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MIN));
> +}
> +static ssize_t show_in_max_alarm(struct device *dev, struct device_attribute
> + *devattr, char *buf)
coding-style nit: it is highly unusual to put a newline between the
argument's type and its identifier.
This:
--- a/drivers/hwmon/pc87360.c~hwmon-pc87360-separate-alarm-files-add-in-min-max-alarms-cleanup
+++ a/drivers/hwmon/pc87360.c
@@ -498,16 +498,16 @@ static struct sensor_device_attribute in
register (sec 11.5.12), not the vin event status registers (sec
11.5.2) that (legacy) show_in_alarm() resds (via data->in_alarms) */
-static ssize_t show_in_min_alarm(struct device *dev, struct device_attribute
- *devattr, char *buf)
+static ssize_t show_in_min_alarm(struct device *dev,
+ struct device_attribute *devattr, char *buf)
{
struct pc87360_data *data = pc87360_update_device(dev);
unsigned nr = to_sensor_dev_attr(devattr)->index;
return sprintf(buf, "%u\n", !!(data->in_status[nr] & CHAN_ALM_MIN));
}
-static ssize_t show_in_max_alarm(struct device *dev, struct device_attribute
- *devattr, char *buf)
+static ssize_t show_in_max_alarm(struct device *dev,
+ struct device_attribute *devattr, char *buf)
{
struct pc87360_data *data = pc87360_update_device(dev);
unsigned nr = to_sensor_dev_attr(devattr)->index;
_
is not really any better-looking, but it's more conventional.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2008-09-11 0:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 9:33 [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate sysfs Jim Cromie
2008-09-10 9:47 ` [lm-sensors] [patch 2.6.27-rc6 2/6] hwmon/pc87360 separate Jim Cromie
2008-09-11 0:03 ` Andrew Morton [this message]
2008-09-11 2:16 ` Jim Cromie
2008-09-11 2:23 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910170327.a332ee30.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.