From: Andrew Morton <akpm@linux-foundation.org>
To: Valdis.Kletnieks@vt.edu
Cc: Marcin Obara <marcin_obara@users.sourceforge.net>,
Jiri Slaby <jirislaby@gmail.com>,
tpm@selhorst.net, kjhall@us.ibm.com,
linux-kernel@vger.kernel.org, srajiv@linux.vnet.ibm.com,
debora@linux.vnet.ibm.com
Subject: Re: tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27
Date: Fri, 12 Sep 2008 08:49:49 -0700 [thread overview]
Message-ID: <20080912084949.008855e5.akpm@linux-foundation.org> (raw)
In-Reply-To: <7218.1221189008@turing-police.cc.vt.edu>
On Thu, 11 Sep 2008 23:10:08 -0400 Valdis.Kletnieks@vt.edu wrote:
> On Thu, 11 Sep 2008 12:03:52 +0200, Marcin Obara said:
>
> > > Why? I wasn't aware that this fixed anything which anyone had observed
> > > (pokes tongue out at the changelog).
> > >
> >
> > This fixes i.e.: long hang while loading TPM driver, if TPM chip
> > starts in "Idle" state instead of "Ready" state.
> > Without this patch - 'modprobe' may hang for 30 seconds or more.
> > Please, push this patch into 2.6.27.
>
> I personally don't care whether this goes into .27 or waits till .28. However,
> I *would* appreciate it if we make sure that whenever it goes go upstream, we
> also send tpm-work-around-bug-in-broadcom-bcm0102-chipset.patch at the same
> time.
>
> I have to admit that it's not exactly confidence inspiring - if the Broadcom
> chip gets timeout units wrong, what *other* issues lurk in its silicon? It's
> bad enough when you find bugs in a RAID chipset or mouse hardware - it's even
> worse when it's a security chip.. ;)
>
hm, it's rather a lot of patching just to fix a once-off 30-second
pause. On second thoughts, let's do it all in 2.6.28.
prev parent reply other threads:[~2008-09-12 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 22:11 tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27 Jiri Slaby
2008-09-10 22:22 ` Andrew Morton
2008-09-11 10:03 ` Marcin Obara
2008-09-12 3:10 ` Valdis.Kletnieks
2008-09-12 15:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080912084949.008855e5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=debora@linux.vnet.ibm.com \
--cc=jirislaby@gmail.com \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin_obara@users.sourceforge.net \
--cc=srajiv@linux.vnet.ibm.com \
--cc=tpm@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.