From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Pekka Enberg <penberg@cs.helsinki.fi>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.28] tcp_ipv6: fix use of uninitialized memory
Date: Fri, 12 Sep 2008 09:44:05 -0300 [thread overview]
Message-ID: <20080912124405.GF8935@ghostprotocols.net> (raw)
In-Reply-To: <20080912070525.GA22276@damson.getinternet.no>
Em Fri, Sep 12, 2008 at 09:05:25AM +0200, Vegard Nossum escreveu:
> >From 6544c4074aa5dde2e3f4d3e02f5601c1c33b770e Mon Sep 17 00:00:00 2001
> From: Vegard Nossum <vegard.nossum@gmail.com>
> Date: Tue, 9 Sep 2008 07:17:32 +0200
> Subject: [PATCH] tcp_ipv6: fix use of uninitialized memory
>
> inet6_rsk() is called on a struct request_sock * before we
> have checked whether the socket is an ipv6 socket or a ipv6-
> mapped ipv4 socket. The access that triggers this is the
> inet_rsk(rsk)->inet6_rsk_offset dereference in inet6_rsk().
>
> This is arguably not a critical error as the inet6_rsk_offset
> is only used to compute a pointer which is never really used
> (in the code path in question) anyway. But it might be a
> latent error, so let's fix it.
>
> Spotted by kmemcheck.
Humm, so this was poisoned at allocation and then when inet6_rsk_offset
was accessed it noticed, interesting, thanks!
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo
next prev parent reply other threads:[~2008-09-12 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 7:05 [PATCH 2.6.28] tcp_ipv6: fix use of uninitialized memory Vegard Nossum
2008-09-12 12:44 ` Arnaldo Carvalho de Melo [this message]
2008-09-12 23:17 ` David Miller
2008-09-14 14:48 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080912124405.GF8935@ghostprotocols.net \
--to=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.