From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 2.6.27-rc6] spi_s3c24xx: fix section warning Date: Fri, 12 Sep 2008 15:52:00 -0700 Message-ID: <20080912155200.3f58c477.akpm@linux-foundation.org> References: <200809120944.13918.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org To: David Brownell Return-path: In-Reply-To: <200809120944.13918.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, 12 Sep 2008 09:44:13 -0700 David Brownell wrote: > From: Ben Dooks > > Fix the section mismatch warning generated by the iconrrect > naming of s3c24xx_spidrv which should be s3c24xx_spi_driver: > > WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4): > Section mismatch in reference from the variable s3c24xx_spidrv > to the (unknown reference) .exit.text:(unknown) > > Signed-off-by: Ben Dooks > Signed-off-by: David Brownell > --- > drivers/spi/spi_s3c24xx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > --- a/drivers/spi/spi_s3c24xx.c > +++ b/drivers/spi/spi_s3c24xx.c > @@ -436,7 +436,7 @@ static int s3c24xx_spi_resume(struct pla > #endif > > MODULE_ALIAS("platform:s3c2410-spi"); > -static struct platform_driver s3c24xx_spidrv = { > +static struct platform_driver s3c24xx_spi_driver = { > .remove = __exit_p(s3c24xx_spi_remove), > .suspend = s3c24xx_spi_suspend, > .resume = s3c24xx_spi_resume, > @@ -448,12 +448,12 @@ static struct platform_driver s3c24xx_sp > > static int __init s3c24xx_spi_init(void) > { > - return platform_driver_probe(&s3c24xx_spidrv, s3c24xx_spi_probe); > + return platform_driver_probe(&s3c24xx_spi_driver, s3c24xx_spi_probe); > } > > static void __exit s3c24xx_spi_exit(void) > { > - platform_driver_unregister(&s3c24xx_spidrv); > + platform_driver_unregister(&s3c24xx_spi_driver); > } > > module_init(s3c24xx_spi_init); whoa. We have kbuild magic which relies unpn a name ending in "_driver"? Why did I just learn that. Do you know if this magic is described anywhere? Thanks. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/