From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: PV-GRUB - Does not read partition-less disk
Date: Fri, 12 Sep 2008 21:38:36 +0200
Message-ID: <20080912193836.GK4171@implementation>
References: <20080911231038.GA5780@wavehammer.waldi.eu.org>
	<20fe3cf60809111838q370a0b66pa848ea46eaef3798@mail.gmail.com>
	<20080912062457.GA20977@wavehammer.waldi.eu.org>
	<20fe3cf60809120501n29e4fc49y6f2a6075bccb8a30@mail.gmail.com>
	<20080912130652.GA4180@wavehammer.waldi.eu.org>
	<20fe3cf60809120729j41c648fep56e618c0d1838d28@mail.gmail.com>
	<20080912144210.GA8234@wavehammer.waldi.eu.org>
	<20fe3cf60809120801kdfde723hcc1b1392aa16370a@mail.gmail.com>
	<20080912191636.GA18956@wavehammer.waldi.eu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20080912191636.GA18956@wavehammer.waldi.eu.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Bastian Blank <bastian@waldi.eu.org>
Cc: xen-devel@lists.xensource.com, Marco Sinhoreli <msinhore@gmail.com>
List-Id: xen-devel@lists.xenproject.org

Bastian Blank, le Fri 12 Sep 2008 21:16:36 +0200, a =E9crit :
> Anyway, I found it. It is buried in the filesystem modules of grub in
> the mount hook.

Cool, I currently don't have much time to spend on these :)

> It checks for
> | ((current_drive & 0x80) || (current_slice !=3D 0))
> |    && (current_slice !=3D PC_SLICE_TYPE_EXT2FS)
> |    && (current_slice !=3D PC_SLICE_TYPE_LINUX_RAID)
> |    && (! IS_PC_SLICE_TYPE_BSD_WITH_FS (current_slice, FS_EXT2FS))
> |    && (! IS_PC_SLICE_TYPE_BSD_WITH_FS (current_slice, FS_OTHER))
>=20
> Which reads as:
> - If device is a harddisk,
> - or it is a slice with none matching type,
> then abort.
>=20
> It simply refuses to find filesystems on the whole disk. If I remove th=
e
> current_disk check it is able to find the filesystem.

Uh, so that's an upstream bug, isn't it?

Samuel