All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Heikki Orsila <heikki.orsila@iki.fi>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Jakub Narebski <jnareb@gmail.com>,
	Christian Couder <chriscool@tuxfamily.org>,
	Andreas Ericsson <ae@op5.se>
Subject: Re: [PATCH] Start conforming code to "git subcmd" style part 3
Date: Sat, 13 Sep 2008 19:08:31 +0200	[thread overview]
Message-ID: <200809131908.34145.trast@student.ethz.ch> (raw)
In-Reply-To: <20080913163058.GA5108@zakalwe.fi>

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

Heikki Orsila wrote:
> diff --git a/builtin-tar-tree.c b/builtin-tar-tree.c
> index cb7007e..edcf72a 100644
> --- a/builtin-tar-tree.c
> +++ b/builtin-tar-tree.c
> @@ -9,19 +9,19 @@
>  
>  static const char tar_tree_usage[] =
>  "git tar-tree [--remote=<repo>] <tree-ish> [basedir]\n"
> -"*** Note that this command is now deprecated; use git-archive instead.";
> +"*** Note that this command is now deprecated; use \"git archive\" instead.";
>  
>  int cmd_tar_tree(int argc, const char **argv, const char *prefix)
>  {
>  	/*
> -	 * git-tar-tree is now a wrapper around git-archive --format=tar
> +	 * "git tar-tree" is now a wrapper around "git archive" --format=tar
>  	 *
>  	 * $0 --remote=<repo> arg... ==>

I think the quotes should go one further to the right:
+	 * "git tar-tree" is now a wrapper around "git archive --format=tar"

The rest looks fine.

- Thomas


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2008-09-13 17:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-13 16:30 [PATCH] Start conforming code to "git subcmd" style part 3 Heikki Orsila
2008-09-13 17:08 ` Thomas Rast [this message]
2008-09-13 17:13   ` Heikki Orsila
  -- strict thread matches above, loose matches on Subject: below --
2008-09-13 17:18 Heikki Orsila
2008-09-16  4:09 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809131908.34145.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=ae@op5.se \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=heikki.orsila@iki.fi \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.