All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Announce][RFC] CFG_ macro renaming
Date: Sun, 14 Sep 2008 00:54:21 +0200	[thread overview]
Message-ID: <20080913225422.027F424927@gemini.denx.de> (raw)
In-Reply-To: <20080913214155.GA32194@game.jcrosoft.org>

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20080913214155.GA32194@game.jcrosoft.org> you wrote:
>
> > Can you create a "deprecated_cfg.h" file that contains directives like:
> > 
> > #ifdef CFG_OLD_PARAMATER
> > #error "CFG_OLD_PARAMETER renamed! Use CONIFIG_NEW_PARAMETER instead!"
> > #endif
> > 
> > for each CFG_* renamed directive?

I think this is a good idea.

> > This should avoid to "lost" some configuration parameters during this 
> > transitory.phase. this file should be included by common.h for example.
> IMHO, I do not think it's needed due to there is no "lost" possible with this kind of script
> 
> git-grep CFG_ | cut -d: -f1 | grep -v -e "CHANGELOG*" | xargs sed -i -e "s:CFG_:CONFIG_SYS_:g"

It may not be needed for code in mainline, but it  is  a  simple  and
efficient  way  to  catch mistakes when someone submits new code that
has been smoldering for some while in some private repository.

It protects against errors, and it doesn't hurt...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A wise person makes his  own  decisions,  a  weak  one  obeys  public
opinion.                                           -- Chinese proverb

  parent reply	other threads:[~2008-09-13 22:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 23:56 [U-Boot] [Announce][RFC] CFG_ macro renaming Jean-Christophe PLAGNIOL-VILLARD
2008-09-02  0:34 ` Wolfgang Denk
2008-09-02  0:59   ` Jean-Christophe PLAGNIOL-VILLARD
2008-09-13 21:38     ` Luigi 'Comio' Mantellini
2008-09-13 21:41       ` Jean-Christophe PLAGNIOL-VILLARD
2008-09-13 22:12         ` Luigi 'Comio' Mantellini
2008-09-13 22:18           ` Jean-Christophe PLAGNIOL-VILLARD
2008-09-13 22:54         ` Wolfgang Denk [this message]
2008-09-02  6:19 ` Markus Klotzbücher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080913225422.027F424927@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.