From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [patch 2.6.27-rc6] spi_s3c24xx: fix section warning Date: Sun, 14 Sep 2008 22:01:33 +0100 Message-ID: <20080914210132.GK322@trinity.fluff.org> References: <200809120944.13918.david-b@pacbell.net> <20080912155200.3f58c477.akpm@linux-foundation.org> <200809121654.08873.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Andrew Morton , ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org To: David Brownell Return-path: Content-Disposition: inline In-Reply-To: <200809121654.08873.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, Sep 12, 2008 at 04:54:08PM -0700, David Brownell wrote: > On Friday 12 September 2008, Andrew Morton wrote: > > On Fri, 12 Sep 2008 09:44:13 -0700 > > David Brownell wrote: > > > > > From: Ben Dooks > > > > > > Fix the section mismatch warning generated by the iconrrect > > > naming of s3c24xx_spidrv which should be s3c24xx_spi_driver: > > > > > > WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4): > > > Section mismatch in reference from the variable s3c24xx_spidrv > > > to the (unknown reference) .exit.text:(unknown) > > > > > > ... > > > > whoa. We have kbuild magic which relies unpn a name ending in "_driver"? > > > > Why did I just learn that. Do you know if this magic is described > > anywhere? > > You probably just learned that because you have better things > to do than run with the appended patch, and then fixing the > resulting warnings (sample shown above) according to the magic > handwaving at secref_whitelist() in scripts/mod/modpost.c ... > > --- > lib/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/lib/Kconfig.debug 2008-07-22 15:27:52.000000000 -0700 > +++ b/lib/Kconfig.debug 2008-07-22 15:31:34.000000000 -0700 > @@ -95,7 +95,7 @@ config HEADERS_CHECK > > config DEBUG_SECTION_MISMATCH > bool "Enable full Section mismatch analysis" > - depends on UNDEFINED > + # depends on UNDEFINED > # This option is on purpose disabled for now. > # It will be enabled when we are down to a resonable number > # of section mismatch warnings (< 10 for an allyesconfig build) I have something similar in my tree. It would be nice to sort this out so it wasn't disabled by default. -- Ben Q: What's a light-year? A: One-third less calories than a regular year. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/