Re: RFC: SDK/external-toolchain fixes

[Denys Dmytriyenko <denis@denix.org>]

On Sat, Sep 13, 2008 at 12:06:43PM -0700, Khem Raj wrote:
> >>>>> gcc 4.3.x has some GCC-provided headers in include-fixed (namely limits.h),
> >>>>> which are missing in the gcc-cross-sdk version, rendering external toolchain
> >>>>> unusable.
> >>>> I do not like this fix. IMO Instead of copying them into include directory
> >>>> they should be let alone in include-fixed directory and packaged. You should
> >>>> add knowledge of this new directory to the failing package instead. What
> >>>> packages are broken because of this.
> >>> I agree that this is not a proper fix, but rather a hack. glibc has its own
> >>> limits.h, which wants to include gcc's limits.h like this:
> >>>
> >>> This issue was brought up before, but as far as I can tell, it wasn't fixed
> >>> properly.
> >>> This is initial Koen's post about the issue:
> >>> http://projects.linuxtogo.org/pipermail/openembedded-devel/2008-April/005108.html
> >>> And here is your own reply with one of the possible solutions:
> >>> http://projects.linuxtogo.org/pipermail/openembedded-devel/2008-April/005111.html
> >>>
> >>
> >> right. So can you try this patch and see if this fixes the problem ?
> 
> I only did cross build/testing no target gcc stuff so I did not see this problem thus far.
> I thought gcc driver should have added include-fixed to default search paths for includes unless you disable it to do so like glibc does in such a case the application should add it to include search paths manually. 
> 
> If you can give more details about this failure on native build. I could try to dig more.

The proper fix seems to work fine. Thanks for applying the patch.

-- 
Denys