Re: [PATCH] b43: Issue warning when RFKILL_INPUT is not enabled

[Michael Buesch <mb@bu3sch.de>]

On Monday 15 September 2008 21:43:06 Larry Finger wrote:
> If the system is misconfigured with CONFIG_RFKILL set but CONFIG_RFKILL_INPUT
> not set, the built-in radio LEDs will not work. In the current code, no warning
> is issued.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---

This is wrong. Please do something like the following:

Index: wireless-testing/drivers/net/wireless/b43/rfkill.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/rfkill.c
+++ wireless-testing/drivers/net/wireless/b43/rfkill.c
@@ -186,6 +186,9 @@ void b43_rfkill_init(struct b43_wldev *d
        if (err)
                b43warn(wl, "Failed to load the rfkill-input module. "
                        "The built-in radio LED will not work.\n");
 #endif /* CONFIG_RFKILL_INPUT */
+
+#if !defined(CONFIG_RFKILL_INPUT) && !defined(CONFIG_RFKILL_INPUT_MODULE)
+       b43warn(wl, "The rfkill-input subsystem is not available. "
+               "The built-in radio LED will not work.\n");
+#endif
 
        err = input_register_polled_device(rfk->poll_dev);


-- 
Greetings Michael.